cache: call Init func directly and return err

Author: Kai Kummerer

internal/cmd/ske/kubeconfig/login/login.go

@@ -57,6 +57,10 @@ func NewCmd(p *print.Printer) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
 
+			if err := cache.Init(); err != nil {
+				return fmt.Errorf("cache init failed: %s", err)
+			}
+
 			env := os.Getenv("KUBERNETES_EXEC_INFO")
 			if env == "" {
 				return fmt.Errorf("%s\n%s\n%s", "KUBERNETES_EXEC_INFO env var is unset or empty.",

internal/pkg/cache/cache.go

@@ -15,15 +15,19 @@ var (
 	ErrorInvalidCacheIdentifier = fmt.Errorf("invalid cache identifier")
 )
 
-func init() {
+func Init() error {
 	cacheDir, err := os.UserCacheDir()
 	if err != nil {
-		panic(fmt.Errorf("get user cache dir: %w", err))
+		return fmt.Errorf("get user cache dir: %w", err)
 	}
 	cacheFolderPath = filepath.Join(cacheDir, "stackit")
+	return nil
 }
 
 func GetObject(identifier string) ([]byte, error) {
+	if err := validateCacheFolderPath(); err != nil {
+		return nil, err
+	}
 	if !identifierRegex.MatchString(identifier) {
 		return nil, ErrorInvalidCacheIdentifier
 	}
@@ -32,6 +36,9 @@ func GetObject(identifier string) ([]byte, error) {
 }
 
 func PutObject(identifier string, data []byte) error {
+	if err := validateCacheFolderPath(); err != nil {
+		return err
+	}
 	if !identifierRegex.MatchString(identifier) {
 		return ErrorInvalidCacheIdentifier
 	}
@@ -45,6 +52,9 @@ func PutObject(identifier string, data []byte) error {
 }
 
 func DeleteObject(identifier string) error {
+	if err := validateCacheFolderPath(); err != nil {
+		return err
+	}
 	if !identifierRegex.MatchString(identifier) {
 		return ErrorInvalidCacheIdentifier
 	}
@@ -67,3 +77,10 @@ func createFolderIfNotExists(folderPath string) error {
 	}
 	return nil
 }
+
+func validateCacheFolderPath() error {
+	if cacheFolderPath == "" {
+		return errors.New("cacheFolderPath not set. Forgot to call Init()?")
+	}
+	return nil
+}

internal/pkg/cache/cache_test.go

@@ -10,6 +10,10 @@ import (
 )
 
 func TestGetObject(t *testing.T) {
+	if err := Init(); err != nil {
+		t.Fatalf("cache init failed: %s", err)
+	}
+
 	tests := []struct {
 		description string
 		identifier  string
@@ -71,7 +75,10 @@ func TestGetObject(t *testing.T) {
 	}
 }
 func TestPutObject(t *testing.T) {
-	// Also test createFolderIfNotExists here
+	if err := Init(); err != nil {
+		t.Fatalf("cache init failed: %s", err)
+	}
+
 	tests := []struct {
 		description  string
 		identifier   string
@@ -142,6 +149,10 @@ func TestPutObject(t *testing.T) {
 }
 
 func TestDeleteObject(t *testing.T) {
+	if err := Init(); err != nil {
+		t.Fatalf("cache init failed: %s", err)
+	}
+
 	tests := []struct {
 		description  string
 		identifier   string