Skip to content

Commit 6f83ab2

Browse files
authored
fix(sqlserverflex): require roles flag on user creation (#657)
the API requires the roles anyways relates to STACKITCLI-125
1 parent 8ebf466 commit 6f83ab2

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

docs/stackit_beta_sqlserverflex_user_create.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ stackit beta sqlserverflex user create [flags]
2222

2323
```
2424
Create a SQLServer Flex user for instance with ID "xxx" and specify the username, role and database
25-
$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_DatabaseManager##" --database my-database
25+
$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_DatabaseManager##"
2626
2727
Create a SQLServer Flex user for instance with ID "xxx", specifying multiple roles
2828
$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_LoginManager##,##STACKIT_DatabaseManager##"

internal/cmd/beta/sqlserverflex/user/create/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
5050
Example: examples.Build(
5151
examples.NewExample(
5252
`Create a SQLServer Flex user for instance with ID "xxx" and specify the username, role and database`,
53-
`$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_DatabaseManager##" --database my-database`),
53+
`$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_DatabaseManager##"`),
5454
examples.NewExample(
5555
`Create a SQLServer Flex user for instance with ID "xxx", specifying multiple roles`,
5656
`$ stackit beta sqlserverflex user create --instance-id xxx --username johndoe --roles "##STACKIT_LoginManager##,##STACKIT_DatabaseManager##"`),
@@ -104,7 +104,7 @@ func configureFlags(cmd *cobra.Command) {
104104
cmd.Flags().String(usernameFlag, "", "Username of the user")
105105
cmd.Flags().StringSlice(rolesFlag, []string{}, "Roles of the user")
106106

107-
err := flags.MarkFlagsRequired(cmd, instanceIdFlag, usernameFlag)
107+
err := flags.MarkFlagsRequired(cmd, instanceIdFlag, usernameFlag, rolesFlag)
108108
cobra.CheckErr(err)
109109
}
110110

internal/cmd/beta/sqlserverflex/user/create/create_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,7 @@ func TestParseInput(t *testing.T) {
9292
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
9393
delete(flagValues, rolesFlag)
9494
}),
95-
isValid: true,
96-
expectedModel: fixtureInputModel(func(model *inputModel) {
97-
model.Roles = nil
98-
}),
95+
isValid: false,
9996
},
10097
{
10198
description: "no values",

0 commit comments

Comments
 (0)