SshClient.Dispose is throwing exception when SSH session gets disconnected unexpectedely

[mauroa]

The disposal of an SshClient instance could end throwing an exception when the SSH Session gets disconnected by the remote host.

A quick look into the code shows that even if the Dispose methods calls Disconnect internally and doesn't have exception handling (https://github.com/sshnet/SSH.NET/blob/develop/src/Renci.SshNet/BaseClient.cs#L339) , there is always a null check over the SshSession (https://github.com/sshnet/SSH.NET/blob/develop/src/Renci.SshNet/BaseClient.cs#L225-L246) to prevent any unwanted NullReferenceException. However, something is still going on when the session is remotely disconnected and the SshClient is tried to be disposed after that.

[drieseng]

This should be fixed in the develop branch.
What version of SSH.NET are you using, and can you easily reproduce this issue?
Would it be possible for you to build SSH.NET from source?
If not, I can send you an assembly built from source.
Just let me know which framework you're targeting.

[icnocop]

@drieseng , Can we utilize the CI appveyor build so that it automatically publishes the output whenever the code changes so that it can be downloaded and used with less effort?

For example, the build can publish the nuget package to any one of these repositories:

1. To nuget and indicate that it's a prerelease build (recommended)
2. To the appveyor project as a build artifact
   Is this already happening? If so, can you provide a link please?
3. To this github project as a "release", but probably indicate that's it's not "official"

Thank you! :)

[Austneal]

Is there a workaround for this, or do we still need to build from the development branch?

[drieseng]

I'm gonna try to ship a new beta this weekend.

[josephearl]

Experiencing this issue on 2016.0, a fix would be great 👍

[drieseng]

This should be fixed in version 2016.1.0-beta1.
Please test and provide feedback.

[josephearl]

Thanks!

[drieseng]

@josephearl Can you confirm that this issue is fixed in 2016.1.0-beta1?

[josephearl]

@drieseng yes works for me

[ogborstad]

Does this release get out of beta soon?