ssh: fix test without SSH_AUTH_SOCK

Author: smola

plumbing/transport/ssh/auth_method_test.go

@@ -94,11 +94,30 @@ func (s *SuiteCommon) TestPublicKeysCallbackString(c *C) {
 	c.Assert(a.String(), Equals, fmt.Sprintf("user: test, name: %s", PublicKeysCallbackName))
 }
 func (s *SuiteCommon) TestNewSSHAgentAuth(c *C) {
+	if os.Getenv("SSH_AUTH_SOCK") == "" {
+		c.Skip("SSH_AUTH_SOCK or SSH_TEST_PRIVATE_KEY are required")
+	}
+
 	auth, err := NewSSHAgentAuth("foo")
 	c.Assert(err, IsNil)
 	c.Assert(auth, NotNil)
 }
 
+func (s *SuiteCommon) TestNewSSHAgentAuthNoAgent(c *C) {
+	addr := os.Getenv("SSH_AUTH_SOCK")
+	err := os.Unsetenv("SSH_AUTH_SOCK")
+	c.Assert(err, IsNil)
+
+	defer func() {
+		err := os.Setenv("SSH_AUTH_SOCK", addr)
+		c.Assert(err, IsNil)
+	}()
+
+	k, err := NewSSHAgentAuth("foo")
+	c.Assert(k, IsNil)
+	c.Assert(err, ErrorMatches, ".*SSH_AUTH_SOCK.*")
+}
+
 func (*SuiteCommon) TestNewPublicKeys(c *C) {
 	auth, err := NewPublicKeys("foo", testdata.PEMBytes["rsa"], "")
 	c.Assert(err, IsNil)