Skip to content

Use mysql KILL to cancel queries #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Use mysql KILL to cancel queries #264

merged 1 commit into from
Oct 10, 2018

Conversation

carlosms
Copy link
Contributor

@carlosms carlosms commented Oct 9, 2018

Fix #241.

gitbase does not support CONNECTION_ID, that's why the code uses SHOW FULL PROCESSLIST and looks for a query match.

cc @src-d/data-retrieval team

@carlosms
Use mysql KILL to cancel queries
2450581 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms carlosms requested review from smola and smacker October 9, 2018 13:46
@smola
Copy link

smola commented Oct 9, 2018

@carlosms If CONNECTION_ID would help doing a more robust implementation of this in the future, please file an issue at go-mysql-server.

@carlosms carlosms mentioned this pull request Oct 9, 2018
Closed
@carlosms carlosms merged commit 32a27d5 into src-d:master Oct 10, 2018
@carlosms carlosms mentioned this pull request Oct 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacker smacker smacker approved these changes

@smola smola Awaiting requested review from smola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosms @smola @smacker