Latest release v0.1.3 throws TypeError

[eiso]

Chrome Version 65.0.3325.181 (Official Build) (64-bit)

Behaviour: click "Run Query" and nothing happens

Developer Tool console:

Uncaught TypeError: window.AbortController is not a constructor
    at t.value (App.js:215)
    at t.value (App.js:261)
    at Object.o (react-dom.production.min.js:15)
    at Object.invokeGuardedCallback (react-dom.production.min.js:16)
    at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.production.min.js:16)
    at c (react-dom.production.min.js:20)
    at p (react-dom.production.min.js:22)
    at m (react-dom.production.min.js:22)
    at f (react-dom.production.min.js:21)
    at v (react-dom.production.min.js:24)

[eiso]

I spent a few minutes investigating this and learned that the AbortController (https://developer.mozilla.org/en-US/docs/Web/API/AbortController) is an experimental feature only enabled since Google Chrome 66. When I upgraded to the latest stable version (68.0.3440.106 (Official Build) (64-bit)) everything worked.

@bzz what are our browser compatibility guidelines?

[bzz]

what are our browser compatibility guidelines?

@eiso it's "recent versions of at least 2 different browsers: Chrome and FF and 🤞 latest Edge (but not tested much)"

yeah, the fetch abort controller is a recent thing (https://caniuse.com/#search=abortcontroller). It should be easy to fix, ignoring it for browsers that don't support it instead of crashing.

As for that, @carlosms we are using abortcontroller-polyfill so could you please help me understand, shall not it "just work" in those browsers where fetch is supported (e.g. Chromium 64)?

Looking at https://github.com/mo/abortcontroller-polyfill#using-it-on-browsers-without-fetch seems like some extra work be needed here in order to make it work in Edge :/ Indeed, for this case it may be easier just to ignore it instead of crashing.

[carlosms]

We are only using the polyfill in the tests setup, not in the application code itself. It should be easy to add to the browser code. From PR #217:

The abort-controller polyfill is used only for the jest tests. All major browsers apparently support AbortCotroller (https://caniuse.com/#search=fetch), and for example for older IE this PR does not break compatibility because it doesn't support fetch API either, which we already use.

About

seems like some extra work be needed here in order to make it work in IE11

I think you got IE and Edge mixed there. IE11 latest release is from 2015, I don't think we want to support that! Edge supports fetch and abort controller.

[bzz]

Thank you for explaining, makes sense.

I think you got IE and Edge mixed there

✅ updated the description above