Make jwks_uri optional for RFC 8414 and required for OpenID Connect #7573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi @jzheaux, I would appreciate the feedback. I also noticed that the As per our conversation on the issue, I have pushed my changes and kept the error message the same as above unless you want it to be different. |
jzheaux
added
in: oauth2
jzheaux
requested changes
Oct 30, 2019
...c/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java
Outdated
Show resolved
Hide resolved
|
@jzheaux pushed my changes relating to your feedback. I will squash my commits once there are no other changes needed to make. 👍 |
|
I find it difficult to come up with good method names. If you think the new method names could be improved, then please feel free to suggest. |
jzheaux
requested changes
Nov 4, 2019
...c/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/oauth2/client/registration/ClientRegistrations.java
Outdated
Show resolved
Hide resolved
...st/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTest.java
Show resolved
Hide resolved
|
Hi @jzheaux, replied to you comments and pushed the recent changes up 👍 |
jzheaux
approved these changes
Nov 5, 2019
OpenID Connect Discovery 1.0 expects the OpenId Provider Metadata response is expected to return a valid jwks_uri, however, this field is optional in the Authorization Server Metadata response as per RFC 8414 specification. Fixes spring-projectsgh-7512
|
Thank you for approving the changes. I have squashed my commits 👍 |
|
Thanks, @rhamedy! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to #7512