Skip to content

Conversation

eberttc
Copy link
Contributor

@eberttc eberttc commented Aug 23, 2019

Since InMemoryReactiveClientRegistrationRepository is intended to be persistent, it should instead use ConcurrentHashMap.

Fixes gh-7299

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 23, 2019
@eddumelendez
Copy link
Contributor

@eberttc update the license's header to Copyright 2002-2019 the original author or authors. and add your name as a author. It is great you are contributing mate :)

@jzheaux jzheaux merged commit 2c2d3b5 into spring-projects:master Aug 24, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 24, 2019

Nice work, @eberttc! This is now merged into master. Thanks again for taking the initiative, and I hope you'll take a look at the tickets marked with status: ideal-for-contribution.

@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Sep 5, 2019
@rwinch rwinch added in: core An issue in spring-security-core status: duplicate A duplicate of another issue labels Sep 5, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Sep 5, 2019
@rwinch rwinch added the type: bug A general bug label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InMemoryReactiveClientRegistrationRepository should not use ConcurrentReferenceHashMap
5 participants