Avoid toString in favor of getName for extract sid

Atry · web-flow · commit 73c5b3733135 · 2019-01-07T10:42:04.000+08:00
There are some more sophisticated implementations of `getName` in `AbstractAuthenticationToken`  and other `Authentication` classes.
diff --git a/acl/src/main/java/org/springframework/security/acls/domain/PrincipalSid.java b/acl/src/main/java/org/springframework/security/acls/domain/PrincipalSid.java
@@ -53,7 +53,7 @@ public PrincipalSid(Authentication authentication) {
 			this.principal = ((UserDetails) authentication.getPrincipal()).getUsername();
 		}
 		else {
-			this.principal = authentication.getPrincipal().toString();
+			this.principal = authentication.getName();
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public PrincipalSid(Authentication authentication) {`
`53`	`53`	`this.principal = ((UserDetails) authentication.getPrincipal()).getUsername();`
`54`	`54`	`}`
`55`	`55`	`else {`
`56`		`- this.principal = authentication.getPrincipal().toString();`
	`56`	`+ this.principal = authentication.getName();`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`