Remove FIXME in OAuth2LoginReactiveAuthenticationManager

jgrandja · jgrandja · commit 7217bb5eb01c · 2019-09-27T12:13:13.000-04:00
diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/authentication/OAuth2LoginReactiveAuthenticationManager.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/authentication/OAuth2LoginReactiveAuthenticationManager.java
@@ -85,8 +85,7 @@ public Mono<Authentication> authenticate(Authentication authentication) {
 					.getAuthorizationRequest().getScopes().contains("openid")) {
 				// This is an OpenID Connect Authentication Request so return null
 				// and let OidcAuthorizationCodeReactiveAuthenticationManager handle it instead once one is created
-				// FIXME: Once we create OidcAuthorizationCodeReactiveAuthenticationManager uncomment below
-//				return Mono.empty();
+				return Mono.empty();
 			}
 
 			return this.authorizationCodeManager.authenticate(token)

Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,7 @@ public Mono<Authentication> authenticate(Authentication authentication) {`
`85`	`85`	`.getAuthorizationRequest().getScopes().contains("openid")) {`
`86`	`86`	`// This is an OpenID Connect Authentication Request so return null`
`87`	`87`	`// and let OidcAuthorizationCodeReactiveAuthenticationManager handle it instead once one is created`
`88`		`- // FIXME: Once we create OidcAuthorizationCodeReactiveAuthenticationManager uncomment below`
`89`		`-// return Mono.empty();`
	`88`	`+ return Mono.empty();`
`90`	`89`	`}`
`91`	`90`
`92`	`91`	`return this.authorizationCodeManager.authenticate(token)`