Skip to content

Commit a8a44ab

Browse files
committed
Drop H2 schema before JDBC tests
https://build.spring.io/browse/INT-MJATS41-1679/
1 parent 33883be commit a8a44ab

File tree

3 files changed

+19
-24
lines changed

3 files changed

+19
-24
lines changed

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/JdbcMessageStoreChannelTests-context.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
http://www.springframework.org/schema/integration/jdbc https://www.springframework.org/schema/integration/jdbc/spring-integration-jdbc.xsd">
1212

1313
<jdbc:embedded-database id="dataSource" type="H2">
14+
<jdbc:script location="org/springframework/integration/jdbc/schema-drop-h2.sql"/>
1415
<jdbc:script location="org/springframework/integration/jdbc/schema-h2.sql"/>
1516
</jdbc:embedded-database>
1617

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/JdbcMessageStoreRegionTests.java

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2016 the original author or authors.
2+
* Copyright 2002-2019 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -18,8 +18,6 @@
1818

1919
import static org.junit.Assert.assertEquals;
2020

21-
import java.sql.ResultSet;
22-
import java.sql.SQLException;
2321
import java.util.List;
2422

2523
import org.junit.After;
@@ -28,28 +26,32 @@
2826
import org.junit.Before;
2927
import org.junit.BeforeClass;
3028
import org.junit.Test;
29+
3130
import org.springframework.integration.support.MessageBuilder;
3231
import org.springframework.jdbc.core.JdbcTemplate;
33-
import org.springframework.jdbc.core.RowMapper;
3432
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabase;
3533
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
3634
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
3735

3836
/**
3937
* @author Gunnar Hillert
38+
* @author Artem Bilan
4039
*/
4140
public class JdbcMessageStoreRegionTests {
4241

4342
private static EmbeddedDatabase dataSource;
43+
4444
private JdbcTemplate jdbcTemplate;
4545

4646
private JdbcMessageStore messageStore1;
47+
4748
private JdbcMessageStore messageStore2;
4849

4950
@BeforeClass
5051
public static void setupDatabase() {
5152
dataSource = new EmbeddedDatabaseBuilder()
5253
.setType(EmbeddedDatabaseType.H2)
54+
.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
5355
.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
5456
.build();
5557
}
@@ -77,7 +79,7 @@ public void afterTest() {
7779
}
7880

7981
@Test
80-
public void testVerifyMessageCount() throws Exception {
82+
public void testVerifyMessageCount() {
8183

8284
messageStore1.addMessage(MessageBuilder.withPayload("payload1").build());
8385
messageStore1.addMessage(MessageBuilder.withPayload("payload2").build());
@@ -91,7 +93,7 @@ public void testVerifyMessageCount() throws Exception {
9193
}
9294

9395
@Test
94-
public void testInsertNullRegion() throws Exception {
96+
public void testInsertNullRegion() {
9597

9698
try {
9799
messageStore1.setRegion(null);
@@ -105,7 +107,7 @@ public void testInsertNullRegion() throws Exception {
105107
}
106108

107109
@Test
108-
public void testVerifyMessageGroupCount() throws Exception {
110+
public void testVerifyMessageGroupCount() {
109111

110112
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
111113
messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -124,38 +126,28 @@ public void testVerifyMessageGroupCount() throws Exception {
124126
}
125127

126128
@Test
127-
public void testRegionSetToMessageGroup() throws Exception {
129+
public void testRegionSetToMessageGroup() {
128130

129131
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
130132

131-
List<String> regions = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region1'", new RowMapper<String>() {
132-
133-
public String mapRow(ResultSet rs, int rowNum) throws SQLException {
134-
return rs.getString("REGION");
135-
}
136-
137-
});
133+
List<String> regions = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region1'",
134+
(rs, rowNum) -> rs.getString("REGION"));
138135

139136
assertEquals(1, regions.size());
140137
assertEquals("region1", regions.get(0));
141138

142139
messageStore2.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
143140

144-
List<String> regions2 = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region2'", new RowMapper<String>() {
145-
146-
public String mapRow(ResultSet rs, int rowNum) throws SQLException {
147-
return rs.getString("REGION");
148-
}
149-
150-
});
141+
List<String> regions2 = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region2'",
142+
(rs, rowNum) -> rs.getString("REGION"));
151143

152144
assertEquals(1, regions2.size());
153145
assertEquals("region2", regions2.get(0));
154146

155147
}
156148

157149
@Test
158-
public void testRemoveMessageGroup() throws Exception {
150+
public void testRemoveMessageGroup() {
159151

160152
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
161153
messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -169,4 +161,5 @@ public void testRemoveMessageGroup() throws Exception {
169161
assertEquals(2, messageStore2.getMessageGroupCount());
170162

171163
}
164+
172165
}

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/leader/JdbcLockRegistryLeaderInitiatorTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public class JdbcLockRegistryLeaderInitiatorTests {
5353
public static void init() {
5454
dataSource = new EmbeddedDatabaseBuilder()
5555
.setType(EmbeddedDatabaseType.H2)
56+
.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
5657
.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
5758
.build();
5859
}
@@ -66,7 +67,7 @@ public static void destroy() {
6667
public void testDistributedLeaderElection() throws Exception {
6768
CountDownLatch granted = new CountDownLatch(1);
6869
CountingPublisher countingPublisher = new CountingPublisher(granted);
69-
List<LockRegistryLeaderInitiator> initiators = new ArrayList<LockRegistryLeaderInitiator>();
70+
List<LockRegistryLeaderInitiator> initiators = new ArrayList<>();
7071
for (int i = 0; i < 2; i++) {
7172
DefaultLockRepository lockRepository = new DefaultLockRepository(dataSource);
7273
lockRepository.afterPropertiesSet();

0 commit comments

Comments
 (0)