Skip to content

Commit 82f252d

Browse files
garyrussellartembilan
authored andcommitted
INT-4390: Fix tangles
JIRA: https://jira.spring.io/browse/INT-4390 Phase I: flow context/registration cycle - extract interfaces - rename implementations to `Standard...` Phase II - dsl<->dsl.channel tangles Move the channel specs to dsl. Fix missing refactorings (Not related to DSL) - rename core `event` package to `events` - avoid collision with event module package - fix tangle caused by `MessageGroupExpiredEvent`. Phase III - dsl<->config.dsl - move classes from config.dsl to dsl (Not related to DSL) - fix many tangles caused by graph being a sub-package of support.management - make `graph` a top-level package (Not related to DSL) - move `IntegrationManagementConfigurer` from `management` to `config` - tangle between core and management * Polishing Copyrights, diamonds, some JavaDocs and What's New
1 parent 7f25cba commit 82f252d

File tree

93 files changed

+967
-693
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

93 files changed

+967
-693
lines changed

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/AmqpPollableMessageChannelSpec.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2014-2016 the original author or authors.
2+
* Copyright 2014-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -26,7 +26,7 @@
2626
import org.springframework.integration.amqp.channel.AbstractAmqpChannel;
2727
import org.springframework.integration.amqp.config.AmqpChannelFactoryBean;
2828
import org.springframework.integration.amqp.support.AmqpHeaderMapper;
29-
import org.springframework.integration.dsl.channel.MessageChannelSpec;
29+
import org.springframework.integration.dsl.MessageChannelSpec;
3030
import org.springframework.util.Assert;
3131

3232
/**
@@ -36,6 +36,7 @@
3636
*
3737
* @author Artem Bilan
3838
* @author Gary Russell
39+
*
3940
* @since 5.0
4041
*/
4142
public class AmqpPollableMessageChannelSpec<S extends AmqpPollableMessageChannelSpec<S>>

spring-integration-core/src/main/java/org/springframework/integration/aggregator/MessageGroupExpiredEvent.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2014-2016 the original author or authors.
2+
* Copyright 2014-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -18,13 +18,14 @@
1818

1919
import java.util.Date;
2020

21-
import org.springframework.integration.event.IntegrationEvent;
21+
import org.springframework.integration.events.IntegrationEvent;
2222
import org.springframework.integration.support.context.NamedComponent;
2323

2424
/**
2525
* Event representing the expiration of a message group.
2626
*
2727
* @author Gary Russell
28+
*
2829
* @since 4.0.1
2930
*/
3031
public class MessageGroupExpiredEvent extends IntegrationEvent {

spring-integration-core/src/main/java/org/springframework/integration/config/EnableIntegrationManagement.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2014-2015 the original author or authors.
2+
* Copyright 2014-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -24,7 +24,6 @@
2424

2525
import org.springframework.context.annotation.Import;
2626
import org.springframework.integration.support.management.IntegrationManagement;
27-
import org.springframework.integration.support.management.IntegrationManagementConfigurer;
2827

2928
/**
3029
* Enables default configuring of management in Spring Integration components in an existing application.
@@ -33,6 +32,7 @@
3332
* bean is defined under the name {@code integrationManagementConfigurer}.
3433
*
3534
* @author Gary Russell
35+
*
3636
* @since 4.2
3737
*/
3838
@Target(ElementType.TYPE)

spring-integration-core/src/main/java/org/springframework/integration/config/IntegrationManagementConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2015 the original author or authors.
2+
* Copyright 2015-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -30,7 +30,6 @@
3030
import org.springframework.core.annotation.AnnotationAttributes;
3131
import org.springframework.core.env.Environment;
3232
import org.springframework.core.type.AnnotationMetadata;
33-
import org.springframework.integration.support.management.IntegrationManagementConfigurer;
3433
import org.springframework.util.Assert;
3534
import org.springframework.util.StringUtils;
3635

@@ -42,6 +41,7 @@
4241
*
4342
* @author Artem Bilan
4443
* @author Gary Russell
44+
*
4545
* @since 4.2
4646
*/
4747
@Configuration
Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.integration.support.management;
17+
package org.springframework.integration.config;
1818

1919
import java.util.Arrays;
2020
import java.util.HashMap;
@@ -31,7 +31,18 @@
3131
import org.springframework.context.ApplicationContext;
3232
import org.springframework.context.ApplicationContextAware;
3333
import org.springframework.integration.core.MessageSource;
34+
import org.springframework.integration.support.management.AbstractMessageChannelMetrics;
35+
import org.springframework.integration.support.management.AbstractMessageHandlerMetrics;
36+
import org.springframework.integration.support.management.ConfigurableMetricsAware;
37+
import org.springframework.integration.support.management.DefaultMetricsFactory;
38+
import org.springframework.integration.support.management.IntegrationManagement;
3439
import org.springframework.integration.support.management.IntegrationManagement.ManagementOverrides;
40+
import org.springframework.integration.support.management.MessageChannelMetrics;
41+
import org.springframework.integration.support.management.MessageHandlerMetrics;
42+
import org.springframework.integration.support.management.MessageSourceMetrics;
43+
import org.springframework.integration.support.management.MessageSourceMetricsConfigurer;
44+
import org.springframework.integration.support.management.MetricsFactory;
45+
import org.springframework.integration.support.management.PollableChannelManagement;
3546
import org.springframework.integration.support.management.metrics.MetricsCaptor;
3647
import org.springframework.integration.support.management.micrometer.MicrometerMetricsCaptor;
3748
import org.springframework.integration.support.utils.PatternMatchUtils;

spring-integration-core/src/main/java/org/springframework/integration/config/dsl/package-info.java

Lines changed: 0 additions & 4 deletions
This file was deleted.

spring-integration-core/src/main/java/org/springframework/integration/config/xml/IntegrationManagementParser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2015-2017 the original author or authors.
2+
* Copyright 2015-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -23,7 +23,7 @@
2323
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
2424
import org.springframework.beans.factory.xml.AbstractBeanDefinitionParser;
2525
import org.springframework.beans.factory.xml.ParserContext;
26-
import org.springframework.integration.support.management.IntegrationManagementConfigurer;
26+
import org.springframework.integration.config.IntegrationManagementConfigurer;
2727

2828
/**
2929
* Parser for the &lt;management/&gt; element.
@@ -37,6 +37,7 @@ public class IntegrationManagementParser extends AbstractBeanDefinitionParser {
3737
@Override
3838
protected String resolveId(Element element, AbstractBeanDefinition definition, ParserContext parserContext)
3939
throws BeanDefinitionStoreException {
40+
4041
return IntegrationManagementConfigurer.MANAGEMENT_CONFIGURER_NAME;
4142
}
4243

spring-integration-core/src/main/java/org/springframework/integration/dsl/Channels.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2017 the original author or authors.
2+
* Copyright 2016-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,14 +19,6 @@
1919
import java.util.Queue;
2020
import java.util.concurrent.Executor;
2121

22-
import org.springframework.integration.dsl.channel.DirectChannelSpec;
23-
import org.springframework.integration.dsl.channel.ExecutorChannelSpec;
24-
import org.springframework.integration.dsl.channel.FluxMessageChannelSpec;
25-
import org.springframework.integration.dsl.channel.MessageChannels;
26-
import org.springframework.integration.dsl.channel.PriorityChannelSpec;
27-
import org.springframework.integration.dsl.channel.PublishSubscribeChannelSpec;
28-
import org.springframework.integration.dsl.channel.QueueChannelSpec;
29-
import org.springframework.integration.dsl.channel.RendezvousChannelSpec;
3022
import org.springframework.integration.store.ChannelMessageStore;
3123
import org.springframework.integration.store.PriorityCapableChannelMessageStore;
3224
import org.springframework.messaging.Message;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016 the original author or authors.
2+
* Copyright 2016-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.integration.dsl.channel;
17+
package org.springframework.integration.dsl;
1818

1919
import org.springframework.integration.channel.DirectChannel;
2020

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016 the original author or authors.
2+
* Copyright 2016-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.integration.dsl.channel;
17+
package org.springframework.integration.dsl;
1818

1919
import java.util.concurrent.Executor;
2020

0 commit comments

Comments
 (0)