Skip to content

Commit 82cbafa

Browse files
artembilangaryrussell
authored andcommitted
Downgrade to Derby-10.13.1.1
Looks like we have started to fail much often since upgrade to the `Derby-10.14.1.0`: cb0d43d That is also related to this https://jira.spring.io/browse/INT-4445 * Remove all the `drop` mentioning for Derby scripts - it just doesn't support `IF EXISTS`. More over we don't need to worry about drops since each test now starts its own fresh embedded DB **Cherry-pick to 5.0.x**
1 parent 7bcf6a0 commit 82cbafa

26 files changed

+36
-73
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ subprojects { subproject ->
9696
commonsIoVersion = '2.4'
9797
commonsNetVersion = '3.5'
9898
curatorVersion = '2.11.1'
99-
derbyVersion = '10.14.1.0'
99+
derbyVersion = '10.13.1.1'
100100
eclipseLinkVersion = '2.6.4'
101101
ftpServerVersion = '1.1.1'
102102
groovyVersion = '2.4.12'
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
# Placeholders for Derby:
2-
int.drop.script=classpath:/org/springframework/integration/jdbc/schema-drop-derby.sql
32
int.schema.script=classpath:/org/springframework/integration/jdbc/schema-derby.sql
43
int.database.incrementer.class=org.springframework.jdbc.support.incrementer.DerbyMaxValueIncrementer

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/AggregatorIntegrationTests-context.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@
2020

2121
<jdbc:embedded-database id="dataSource" type="DERBY"/>
2222

23-
<jdbc:initialize-database data-source="dataSource"
24-
ignore-failures="ALL">
25-
<jdbc:script location="${int.drop.script}"/>
23+
<jdbc:initialize-database data-source="dataSource">
2624
<jdbc:script location="${int.schema.script}"/>
2725
</jdbc:initialize-database>
2826

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/AggregatorIntegrationTests.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2014-2016 the original author or authors.
2+
* Copyright 2014-2018 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -24,11 +24,13 @@
2424
import java.util.concurrent.CountDownLatch;
2525
import java.util.concurrent.TimeUnit;
2626

27+
import org.junit.After;
2728
import org.junit.Test;
2829
import org.junit.runner.RunWith;
2930

3031
import org.springframework.beans.factory.annotation.Autowired;
3132
import org.springframework.integration.IntegrationMessageHeaderAccessor;
33+
import org.springframework.integration.aggregator.AggregatingMessageHandler;
3234
import org.springframework.integration.store.MessageGroupStore;
3335
import org.springframework.messaging.Message;
3436
import org.springframework.messaging.MessageChannel;
@@ -44,6 +46,7 @@
4446

4547
/**
4648
* @author Artem Bilan
49+
*
4750
* @since 4.1
4851
*/
4952
@ContextConfiguration
@@ -57,6 +60,14 @@ public class AggregatorIntegrationTests {
5760
@Autowired
5861
private MessageGroupStore messageGroupStore;
5962

63+
@Autowired
64+
private AggregatingMessageHandler aggregatingMessageHandler;
65+
66+
@After
67+
public void tearDown() {
68+
this.aggregatingMessageHandler.stop();
69+
}
70+
6071
@Test
6172
public void testTransactionalAggregatorGroupTimeout() throws InterruptedException {
6273
this.transactionalAggregatorInput.send(new GenericMessage<Integer>(1, stubHeaders(1, 2, 1)));

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/StoredProcJmxManagedBeanTests-context.xml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,12 @@
22
<beans xmlns="http://www.springframework.org/schema/beans"
33
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xmlns:int="http://www.springframework.org/schema/integration"
5-
xmlns:jdbc="http://www.springframework.org/schema/jdbc"
65
xmlns:int-jdbc="http://www.springframework.org/schema/integration/jdbc"
7-
xmlns:tx="http://www.springframework.org/schema/tx"
8-
xmlns:util="http://www.springframework.org/schema/util"
9-
xmlns:p="http://www.springframework.org/schema/p"
106
xmlns:context="http://www.springframework.org/schema/context"
11-
xsi:schemaLocation="http://www.springframework.org/schema/jdbc http://www.springframework.org/schema/jdbc/spring-jdbc.xsd
12-
http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd
7+
xsi:schemaLocation="http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd
138
http://www.springframework.org/schema/integration/jdbc http://www.springframework.org/schema/integration/jdbc/spring-integration-jdbc.xsd
149
http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd
15-
http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util.xsd
16-
http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context.xsd
17-
http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx.xsd">
10+
http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context.xsd">
1811

1912
<context:mbean-server />
2013
<context:mbean-export default-domain="org.springframework.integration.jdbc.test" />

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/config/JdbcOutboundAdapterWithPollerTest-context.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
<jdbc:embedded-database type="H2" id="dataSource"/>
2727

28-
<jdbc:initialize-database data-source="dataSource" ignore-failures="DROPS">
28+
<jdbc:initialize-database data-source="dataSource">
2929
<jdbc:script location="org/springframework/integration/jdbc/config/outboundPollerSchema.sql" />
3030
</jdbc:initialize-database>
3131

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/config/JdbcOutboundGatewayWithPoller2Test-context.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
<jdbc:embedded-database id="dataSource" type="H2"/>
2727

28-
<jdbc:initialize-database data-source="dataSource" ignore-failures="DROPS">
28+
<jdbc:initialize-database data-source="dataSource">
2929
<jdbc:script location="classpath:org/springframework/integration/jdbc/config/outboundPollerSchema.sql"/>
3030
</jdbc:initialize-database>
3131

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/config/JdbcOutboundGatewayWithPollerTest-context.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
<jdbc:embedded-database id="dataSource" type="H2"/>
3333

34-
<jdbc:initialize-database data-source="dataSource" ignore-failures="DROPS">
34+
<jdbc:initialize-database data-source="dataSource">
3535
<jdbc:script location="classpath:org/springframework/integration/jdbc/config/outboundPollerSchema.sql"/>
3636
</jdbc:initialize-database>
3737

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/config/JdbcOutboundGatewayWithSelectTest-context.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
<jdbc:embedded-database id="dataSource" type="H2"/>
2929

30-
<jdbc:initialize-database data-source="dataSource" ignore-failures="DROPS">
30+
<jdbc:initialize-database data-source="dataSource">
3131
<jdbc:script location="classpath:org/springframework/integration/jdbc/config/outboundPollerSchemaWithData.sql"/>
3232
</jdbc:initialize-database>
3333

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/config/jdbcOutboundChannelAdapterCommonConfig.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
<jdbc:embedded-database type="H2" id="dataSource"/>
1313

14-
<jdbc:initialize-database data-source="dataSource" ignore-failures="DROPS">
14+
<jdbc:initialize-database data-source="dataSource">
1515
<jdbc:script location="classpath:org/springframework/integration/jdbc/config/outboundSchema.sql"/>
1616
</jdbc:initialize-database>
1717

0 commit comments

Comments
 (0)