Use OS-selected port in failed TCP test

https://build.spring.io/browse/INT-AT42SIO-456/

Author: artembilan

spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/connection/CachingClientConnectionFactoryTests-context.xml

@@ -7,13 +7,11 @@
 		http://www.springframework.org/schema/integration http://www.springframework.org/schema/integration/spring-integration.xsd
 		http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd">
 
-	<bean id="tcpIpUtils" class="org.springframework.integration.test.util.SocketUtils" />
-
 	<int-ip:tcp-connection-factory
-		id="scf"
-		type="server"
-		so-timeout="60000"
-		port="#{tcpIpUtils.findAvailableServerSocket()}"/>
+			id="scf"
+			type="server"
+			so-timeout="60000"
+			port="0" />
 
 	<int-ip:tcp-inbound-channel-adapter
 		connection-factory="scf"
@@ -29,14 +27,14 @@
 
 	<int:channel id="replies" />
 
+	<!-- Since we use OS-assigning port in the server, this definition is for example.
+	The real port is assigned to client in test code via reflection. -->
 	<int-ip:tcp-connection-factory
-		id="ccf"
-		type="client"
-		host="localhost"
-		port="#{scf.port}"
-		so-timeout="60000"
-
-	/>
+			id="ccf"
+			type="client"
+			host="localhost"
+			port="#{scf.port}"
+			so-timeout="60000" />
 
 	<bean id="caching.ccf" class="org.springframework.integration.ip.tcp.connection.CachingClientConnectionFactory">
 		<constructor-arg ref="ccf" />
@@ -50,6 +48,8 @@
 
 	<int:channel id="outbound" />
 
+	<!-- Since we use OS-assigning port in the server, this definition is for example.
+	The real port is assigned to client in test code via reflection. -->
 	<int-ip:tcp-connection-factory
 		id="gateway.ccf"
 		type="client"

spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/connection/CachingClientConnectionFactoryTests.java

@@ -117,7 +117,15 @@ public class CachingClientConnectionFactoryTests {
 
 	@Autowired
 	@Qualifier("gateway.caching.ccf")
-	CachingClientConnectionFactory gatewayCF;
+	private CachingClientConnectionFactory gatewayCF;
+
+	@Autowired
+	@Qualifier("gateway.ccf")
+	private AbstractClientConnectionFactory clientGatewayCf;
+
+	@Autowired
+	@Qualifier("ccf")
+	private AbstractClientConnectionFactory clientAdapterCf;
 
 	@Test
 	public void testReuse() throws Exception {
@@ -446,7 +454,9 @@ private TcpConnectionSupport makeMockConnection(String name, boolean closeOk) {
 	@Test
 	public void integrationTest() throws Exception {
 		TestingUtilities.waitListening(serverCf, null);
-		outbound.send(new GenericMessage<String>("Hello, world!"));
+		new DirectFieldAccessor(this.clientAdapterCf).setPropertyValue("port", this.serverCf.getPort());
+
+		this.outbound.send(new GenericMessage<>("Hello, world!"));
 		Message<?> m = inbound.receive(10000);
 		assertNotNull(m);
 		String connectionId = m.getHeaders().get(IpHeaders.CONNECTION_ID, String.class);
@@ -480,7 +490,9 @@ public void run() {
 
 		});
 		TestingUtilities.waitListening(serverCf, null);
-		toGateway.send(new GenericMessage<String>("Hello, world!"));
+		new DirectFieldAccessor(this.clientGatewayCf).setPropertyValue("port", this.serverCf.getPort());
+
+		this.toGateway.send(new GenericMessage<>("Hello, world!"));
 		Message<?> m = fromGateway.receive(1000);
 		assertNotNull(m);
 		assertEquals("foo:" + "Hello, world!", new String((byte[]) m.getPayload()));
@@ -507,18 +519,17 @@ public void run() {
 
 	@Test
 	public void testCloseOnTimeoutNet() throws Exception {
-		TcpNetClientConnectionFactory cf = new TcpNetClientConnectionFactory("localhost", serverCf.getPort());
-		testCloseOnTimeoutGuts(cf);
+		TestingUtilities.waitListening(serverCf, null);
+		testCloseOnTimeoutGuts(new TcpNetClientConnectionFactory("localhost", serverCf.getPort()));
 	}
 
 	@Test
 	public void testCloseOnTimeoutNio() throws Exception {
-		TcpNioClientConnectionFactory cf = new TcpNioClientConnectionFactory("localhost", serverCf.getPort());
-		testCloseOnTimeoutGuts(cf);
+		TestingUtilities.waitListening(serverCf, null);
+		testCloseOnTimeoutGuts(new TcpNioClientConnectionFactory("localhost", serverCf.getPort()));
 	}
 
 	private void testCloseOnTimeoutGuts(AbstractClientConnectionFactory cf) throws Exception {
-		TestingUtilities.waitListening(serverCf, null);
 		cf.setSoTimeout(100);
 		CachingClientConnectionFactory cccf = new CachingClientConnectionFactory(cf, 1);
 		cccf.start();