Sonar - protected fields

Author: garyrussell

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/AmqpBaseOutboundEndpointSpec.java

@@ -44,7 +44,7 @@
 AmqpBaseOutboundEndpointSpec<S extends AmqpBaseOutboundEndpointSpec<S, E>, E extends AbstractAmqpOutboundEndpoint>
 		extends MessageHandlerSpec<S, E> {
 
-	protected final DefaultAmqpHeaderMapper headerMapper = DefaultAmqpHeaderMapper.outboundMapper();
+	protected final DefaultAmqpHeaderMapper headerMapper = DefaultAmqpHeaderMapper.outboundMapper(); // NOSONAR final
 
 	/**
 	 * Set a custom {@link AmqpHeaderMapper} for mapping request and reply headers.

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/AmqpInboundChannelAdapterSpec.java

@@ -40,7 +40,7 @@ public abstract class AmqpInboundChannelAdapterSpec
 		extends AmqpBaseInboundChannelAdapterSpec<S>
 		implements ComponentsRegistration {
 
-	protected final AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec;
+	protected final AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec; // NOSONAR final
 
 	AmqpInboundChannelAdapterSpec(AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec) {
 		super(new AmqpInboundChannelAdapter(listenerContainerSpec.get()));

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/AmqpInboundGatewaySpec.java

@@ -40,7 +40,7 @@ public abstract class AmqpInboundGatewaySpec
 		extends AmqpBaseInboundGatewaySpec<S>
 		implements ComponentsRegistration {
 
-	protected final AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec;
+	protected final AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec; // NOSONAR final
 
 	AmqpInboundGatewaySpec(AbstractMessageListenerContainerSpec<?, C> listenerContainerSpec) {
 		super(new AmqpInboundGateway(listenerContainerSpec.get()));

spring-integration-amqp/src/main/java/org/springframework/integration/amqp/dsl/AmqpPollableMessageChannelSpec.java

@@ -42,7 +42,7 @@
 public class AmqpPollableMessageChannelSpec<S extends AmqpPollableMessageChannelSpec<S>>
 		extends MessageChannelSpec<S, AbstractAmqpChannel> {
 
-	protected final AmqpChannelFactoryBean amqpChannelFactoryBean;
+	protected final AmqpChannelFactoryBean amqpChannelFactoryBean; // NOSONAR final
 
 	AmqpPollableMessageChannelSpec(ConnectionFactory connectionFactory) {
 		this(new AmqpChannelFactoryBean(false), connectionFactory);

spring-integration-core/src/main/java/org/springframework/integration/channel/QueueChannel.java

@@ -47,7 +47,7 @@ public class QueueChannel extends AbstractPollableChannel implements QueueChanne
 
 	private final Queue<Message<?>> queue;
 
-	protected final Semaphore queueSemaphore = new Semaphore(0);
+	protected final Semaphore queueSemaphore = new Semaphore(0); // NOSONAR final
 
 	/**
 	 * Create a channel with the specified queue.

spring-integration-core/src/main/java/org/springframework/integration/codec/kryo/AbstractKryoCodec.java

@@ -39,7 +39,7 @@
  */
 public abstract class AbstractKryoCodec implements Codec {
 
-	protected final KryoPool pool;
+	protected final KryoPool pool; // NOSONAR final
 
 	protected AbstractKryoCodec() {
 		KryoFactory factory = () -> {
@@ -53,7 +53,7 @@ protected AbstractKryoCodec() {
 	}
 
 	@Override
-	public void encode(final Object object, OutputStream outputStream) throws IOException {
+	public void encode(final Object object, OutputStream outputStream) {
 		Assert.notNull(object, "cannot encode a null object");
 		Assert.notNull(outputStream, "'outputSteam' cannot be null");
 		final Output output = (outputStream instanceof Output ? (Output) outputStream : new Output(outputStream));
@@ -77,7 +77,7 @@ public <T> T decode(byte[] bytes, Class<T> type) throws IOException {
 	}
 
 	@Override
-	public <T> T decode(InputStream inputStream, final Class<T> type) throws IOException {
+	public <T> T decode(InputStream inputStream, final Class<T> type) {
 		Assert.notNull(inputStream, "'inputStream' cannot be null");
 		Assert.notNull(type, "'type' cannot be null");
 		final Input input = (inputStream instanceof Input ? (Input) inputStream : new Input(inputStream));

spring-integration-core/src/main/java/org/springframework/integration/config/xml/AbstractIntegrationNamespaceHandler.java

@@ -46,7 +46,7 @@ public abstract class AbstractIntegrationNamespaceHandler implements NamespaceHa
 
 	private static final String VERSION = "5.2";
 
-	protected final Log logger = LogFactory.getLog(this.getClass());
+	protected final Log logger = LogFactory.getLog(this.getClass()); // NOSONAR final
 
 	private final NamespaceHandlerDelegate delegate = new NamespaceHandlerDelegate();
 

spring-integration-core/src/main/java/org/springframework/integration/core/ErrorMessagePublisher.java

@@ -50,9 +50,9 @@
  */
 public class ErrorMessagePublisher implements BeanFactoryAware {
 
-	protected final Log logger = LogFactory.getLog(getClass());
+	protected final Log logger = LogFactory.getLog(getClass()); // NOSONAR final
 
-	protected final MessagingTemplate messagingTemplate = new MessagingTemplate();
+	protected final MessagingTemplate messagingTemplate = new MessagingTemplate(); // NOSONAR final
 
 	private DestinationResolver<MessageChannel> channelResolver;
 

spring-integration-core/src/main/java/org/springframework/integration/dispatcher/AbstractDispatcher.java

@@ -43,7 +43,7 @@
  */
 public abstract class AbstractDispatcher implements MessageDispatcher {
 
-	protected final Log logger = LogFactory.getLog(this.getClass());
+	protected final Log logger = LogFactory.getLog(getClass()); // NOSONAR final
 
 	private volatile int maxSubscribers = Integer.MAX_VALUE;
 

spring-integration-core/src/main/java/org/springframework/integration/dispatcher/RoundRobinLoadBalancingStrategy.java

@@ -65,7 +65,7 @@ private Iterator<MessageHandler> buildHandlerIterator(int size, final MessageHan
 
 		return new Iterator<MessageHandler>() {
 
-			int currentIndex = 0;
+			private int currentIndex = 0;
 
 			public boolean hasNext() {
 				return this.currentIndex < reorderedHandlers.length;