INT-4378: TCP Fix CF Name in Intercepted Events

JIRA: https://jira.spring.io/browse/INT-4378

Events (e.g. `TcpConnectionOpenEvent` from intercepted connections contain an
'unknown' connection factory name.

Delegate to the underlying connection's factory name.

Author: garyrussell

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/TcpConnectionInterceptorSupport.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -106,6 +106,11 @@ public SocketInfo getSocketInfo() {
 		return this.theConnection.getSocketInfo();
 	}
 
+	@Override
+	public String getConnectionFactoryName() {
+		return this.theConnection.getConnectionFactoryName();
+	}
+
 	@Override
 	public void run() {
 		this.theConnection.run();

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/TcpConnectionSupport.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2001-2016 the original author or authors.
+ * Copyright 2001-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -328,6 +328,10 @@ public SocketInfo getSocketInfo() {
 		return this.socketInfo;
 	}
 
+	public String getConnectionFactoryName() {
+		return this.connectionFactoryName;
+	}
+
 	protected boolean isNoReadErrorOnClose() {
 		return this.noReadErrorOnClose;
 	}
@@ -347,19 +351,19 @@ protected final void sendExceptionToListener(Exception e) {
 
 	protected void publishConnectionOpenEvent() {
 		TcpConnectionEvent event = new TcpConnectionOpenEvent(this,
-				this.connectionFactoryName);
+				getConnectionFactoryName());
 		doPublish(event);
 	}
 
 	protected void publishConnectionCloseEvent() {
 		TcpConnectionEvent event = new TcpConnectionCloseEvent(this,
-				this.connectionFactoryName);
+				getConnectionFactoryName());
 		doPublish(event);
 	}
 
 	protected void publishConnectionExceptionEvent(Throwable t) {
 		TcpConnectionEvent event = new TcpConnectionExceptionEvent(this,
-				this.connectionFactoryName, t);
+				getConnectionFactoryName(), t);
 		doPublish(event);
 	}
 

spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/InterceptedSharedConnectionTests-context.xml

@@ -71,4 +71,6 @@
 
 	<int:channel id="loop" />
 
+	<bean class="org.springframework.integration.ip.tcp.InterceptedSharedConnectionTests$Listener" />
+
 </beans>

spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/InterceptedSharedConnectionTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,8 +16,11 @@
 
 package org.springframework.integration.ip.tcp;
 
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.notNullValue;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
 
 import org.apache.log4j.Level;
 import org.apache.log4j.LogManager;
@@ -27,11 +30,14 @@
 import org.junit.runner.RunWith;
 
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.ApplicationListener;
 import org.springframework.context.support.AbstractApplicationContext;
 import org.springframework.integration.channel.QueueChannel;
 import org.springframework.integration.config.ConsumerEndpointFactoryBean;
 import org.springframework.integration.ip.tcp.connection.AbstractClientConnectionFactory;
 import org.springframework.integration.ip.tcp.connection.AbstractServerConnectionFactory;
+import org.springframework.integration.ip.tcp.connection.HelloWorldInterceptor;
+import org.springframework.integration.ip.tcp.connection.TcpConnectionOpenEvent;
 import org.springframework.integration.ip.util.TestingUtilities;
 import org.springframework.integration.support.MessageBuilder;
 import org.springframework.messaging.Message;
@@ -58,6 +64,9 @@ public class InterceptedSharedConnectionTests {
 	@Autowired
 	AbstractClientConnectionFactory client;
 
+	@Autowired
+	Listener listener;
+
 	private static Level existingLogLevel;
 
 	// temporary hooks to investigate CI failures
@@ -95,6 +104,21 @@ public void test1() throws Exception {
 			assertNotNull(message);
 			assertEquals("Test", message.getPayload());
 		}
+		assertThat(this.listener.openEvent, notNullValue());
+		assertThat(this.listener.openEvent.getConnectionFactoryName(), equalTo("client"));
+	}
+
+	public static class Listener implements ApplicationListener<TcpConnectionOpenEvent> {
+
+		private volatile TcpConnectionOpenEvent openEvent;
+
+		@Override
+		public void onApplicationEvent(TcpConnectionOpenEvent event) {
+			if (event.getSource() instanceof HelloWorldInterceptor) {
+				this.openEvent = event;
+			}
+		}
+
 	}
 
 }