Do not apply ContextDataFetcherDecorator to TrivialDataFetcher instances #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `applyDecorator` method is working to exclude things from graphql-java. the TrivialDataFetcher interface is used to know when to perform instrumentation and is a part of the public SPI and should be preserved.
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: enhancement
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Jun 3, 2024
The `applyDecorator` method is working to exclude things from graphql-java. The TrivialDataFetcher interface is used to know when to perform instrumentation and is a part of the public SPI and should be preserved. See gh-983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
applyDecoratormethod is working to exclude things from graphql-java. the TrivialDataFetcher interface is used to know when to perform instrumentation and is a part of the public SPI and should be preserved.(checkstyle told me to use tabs, but then that looks weirds on GH - apologies if that is wrong!)