From 046cef6b737d4af15fc3ba5e0ddaf5ecf3d2d687 Mon Sep 17 00:00:00 2001 From: Koen Punt Date: Tue, 27 Jun 2023 15:13:27 +0200 Subject: [PATCH] fix: correctly retrieve operation from request body --- .../org/springframework/graphql/server/WebGraphQlRequest.java | 4 ++-- .../graphql/server/WebGraphQlRequestTests.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-graphql/src/main/java/org/springframework/graphql/server/WebGraphQlRequest.java b/spring-graphql/src/main/java/org/springframework/graphql/server/WebGraphQlRequest.java index b794ddc2e..cfe750ea8 100644 --- a/spring-graphql/src/main/java/org/springframework/graphql/server/WebGraphQlRequest.java +++ b/spring-graphql/src/main/java/org/springframework/graphql/server/WebGraphQlRequest.java @@ -105,9 +105,9 @@ private static String getQuery(Map body) { @Nullable private static String getOperation(Map body) { - Object value = body.get("operation"); + Object value = body.get("operationName"); if (value != null && !(value instanceof String)) { - throw new ServerWebInputException("Invalid value for 'operation'"); + throw new ServerWebInputException("Invalid value for 'operationName'"); } return (String) value; } diff --git a/spring-graphql/src/test/java/org/springframework/graphql/server/WebGraphQlRequestTests.java b/spring-graphql/src/test/java/org/springframework/graphql/server/WebGraphQlRequestTests.java index c6e18ea8e..095633c06 100644 --- a/spring-graphql/src/test/java/org/springframework/graphql/server/WebGraphQlRequestTests.java +++ b/spring-graphql/src/test/java/org/springframework/graphql/server/WebGraphQlRequestTests.java @@ -39,7 +39,7 @@ public class WebGraphQlRequestTests { void invalidBody() { testInvalidBody(Map.of()); testInvalidBody(Map.of("query", Collections.emptyMap())); - testInvalidBody(Map.of("query", "query { foo }", "operation", Collections.emptyMap())); + testInvalidBody(Map.of("query", "query { foo }", "operationName", Collections.emptyMap())); testInvalidBody(Map.of("query", "query { foo }", "variables", "not-a-map")); testInvalidBody(Map.of("query", "query { foo }", "extensions", "not-a-map")); }