Skip to content

Commit eb1c230

Browse files
mp911demp911de
committed
Polishing.
Simplify JdbcArrayColumns from a dialect. Simplify DataAccessStrategyFactory creation. Remove superfluous overrides. See #687 Original pull request: #1704
1 parent 3ed4dea commit eb1c230

File tree

10 files changed

+101
-80
lines changed

10 files changed

+101
-80
lines changed

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DataAccessStrategyFactory.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jdbc.core.convert;
1717

18+
import org.springframework.data.relational.core.dialect.Dialect;
1819
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
1920
import org.springframework.util.Assert;
2021

@@ -37,6 +38,21 @@ public class DataAccessStrategyFactory {
3738
private final InsertStrategyFactory insertStrategyFactory;
3839
private final QueryMappingConfiguration queryMappingConfiguration;
3940

41+
/**
42+
* Creates a new {@link DataAccessStrategyFactory}.
43+
*
44+
* @param converter must not be {@literal null}.
45+
* @param operations must not be {@literal null}.
46+
* @param dialect must not be {@literal null}.
47+
* @param queryMappingConfiguration must not be {@literal null}.
48+
* @since 4.0
49+
*/
50+
public DataAccessStrategyFactory(JdbcConverter converter, NamedParameterJdbcOperations operations, Dialect dialect,
51+
QueryMappingConfiguration queryMappingConfiguration) {
52+
this(new SqlGeneratorSource(converter, dialect), converter, operations, new SqlParametersFactory(converter),
53+
new InsertStrategyFactory(operations, dialect), queryMappingConfiguration);
54+
}
55+
4056
/**
4157
* Creates a new {@link DataAccessStrategyFactory}.
4258
*
@@ -66,6 +82,7 @@ public DataAccessStrategyFactory(SqlGeneratorSource sqlGeneratorSource, JdbcConv
6682
this.queryMappingConfiguration = queryMappingConfiguration;
6783
}
6884

85+
6986
/**
7087
* Creates a new {@link DataAccessStrategy}.
7188
*

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGeneratorSource.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ public class SqlGeneratorSource {
3737
private final JdbcConverter converter;
3838
private final Dialect dialect;
3939

40+
/**
41+
* @param converter must not be {@literal null}.
42+
* @param dialect must not be {@literal null}.
43+
* @since 4.0
44+
*/
45+
public SqlGeneratorSource(JdbcConverter converter, Dialect dialect) {
46+
this(converter.getMappingContext(), converter, dialect);
47+
}
48+
4049
public SqlGeneratorSource(RelationalMappingContext context, JdbcConverter converter, Dialect dialect) {
4150

4251
Assert.notNull(context, "Context must not be null");

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlParametersFactory.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,13 @@ public class SqlParametersFactory {
5252
private final RelationalMappingContext context;
5353
private final JdbcConverter converter;
5454

55+
/**
56+
* @since 4.0
57+
*/
58+
public SqlParametersFactory(JdbcConverter converter) {
59+
this(converter.getMappingContext(), converter);
60+
}
61+
5562
/**
5663
* @since 3.1
5764
*/

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/dialect/JdbcDialect.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,17 @@ default JdbcArrayColumns getArraySupport() {
3737
return JdbcArrayColumns.Unsupported.INSTANCE;
3838
}
3939

40+
/**
41+
* Returns the {@link JdbcArrayColumns array support} for the given {@link Dialect}. Defaults to
42+
* {@link JdbcArrayColumns.Unsupported} iff the dialect is not an instance of {@code JdbcDialect}.
43+
*
44+
* @param dialect the dialect to check for array support.
45+
* @return the {@link JdbcArrayColumns} instance that describes how array-typed columns are supported by the dialect.
46+
* @since 4.0
47+
*/
48+
static JdbcArrayColumns getArraySupport(Dialect dialect) {
49+
return dialect instanceof JdbcDialect jdbcDialect ? jdbcDialect.getArraySupport()
50+
: JdbcArrayColumns.DefaultSupport.INSTANCE;
51+
}
52+
4053
}

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/mybatis/MyBatisDataAccessStrategy.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,19 @@
2828
import org.apache.ibatis.cursor.Cursor;
2929
import org.apache.ibatis.session.SqlSession;
3030
import org.mybatis.spring.SqlSessionTemplate;
31+
3132
import org.springframework.dao.EmptyResultDataAccessException;
3233
import org.springframework.data.domain.Pageable;
3334
import org.springframework.data.domain.Sort;
34-
import org.springframework.data.jdbc.core.convert.*;
35+
import org.springframework.data.jdbc.core.convert.CascadingDataAccessStrategy;
36+
import org.springframework.data.jdbc.core.convert.DataAccessStrategy;
37+
import org.springframework.data.jdbc.core.convert.DataAccessStrategyFactory;
38+
import org.springframework.data.jdbc.core.convert.DefaultDataAccessStrategy;
39+
import org.springframework.data.jdbc.core.convert.DelegatingDataAccessStrategy;
40+
import org.springframework.data.jdbc.core.convert.Identifier;
41+
import org.springframework.data.jdbc.core.convert.InsertSubject;
42+
import org.springframework.data.jdbc.core.convert.JdbcConverter;
43+
import org.springframework.data.jdbc.core.convert.QueryMappingConfiguration;
3544
import org.springframework.data.jdbc.core.dialect.DialectResolver;
3645
import org.springframework.data.mapping.PersistentPropertyPath;
3746
import org.springframework.data.mapping.PropertyPath;
@@ -94,18 +103,8 @@ public static DataAccessStrategy createCombinedAccessStrategy(RelationalMappingC
94103
JdbcConverter converter, NamedParameterJdbcOperations operations, SqlSession sqlSession,
95104
NamespaceStrategy namespaceStrategy, Dialect dialect, QueryMappingConfiguration queryMappingConfiguration) {
96105

97-
SqlGeneratorSource sqlGeneratorSource = new SqlGeneratorSource(context, converter, dialect);
98-
SqlParametersFactory sqlParametersFactory = new SqlParametersFactory(context, converter);
99-
InsertStrategyFactory insertStrategyFactory = new InsertStrategyFactory(operations, dialect);
100-
101-
DataAccessStrategy defaultDataAccessStrategy = new DataAccessStrategyFactory( //
102-
sqlGeneratorSource, //
103-
converter, //
104-
operations, //
105-
sqlParametersFactory, //
106-
insertStrategyFactory, //
107-
queryMappingConfiguration //
108-
).create();
106+
DataAccessStrategy defaultDataAccessStrategy = new DataAccessStrategyFactory(converter, operations, dialect,
107+
queryMappingConfiguration).create();
109108

110109
// the DefaultDataAccessStrategy needs a reference to the returned DataAccessStrategy. This creates a dependency
111110
// cycle. In order to create it, we need something that allows to defer closing the cycle until all the elements are

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfiguration.java

Lines changed: 22 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525

2626
import org.apache.commons.logging.Log;
2727
import org.apache.commons.logging.LogFactory;
28+
2829
import org.springframework.beans.BeansException;
29-
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
3030
import org.springframework.context.ApplicationContext;
3131
import org.springframework.context.ApplicationContextAware;
3232
import org.springframework.context.annotation.Bean;
@@ -36,12 +36,20 @@
3636
import org.springframework.data.convert.CustomConversions;
3737
import org.springframework.data.jdbc.core.JdbcAggregateOperations;
3838
import org.springframework.data.jdbc.core.JdbcAggregateTemplate;
39-
import org.springframework.data.jdbc.core.convert.*;
39+
import org.springframework.data.jdbc.core.convert.DataAccessStrategy;
40+
import org.springframework.data.jdbc.core.convert.DataAccessStrategyFactory;
41+
import org.springframework.data.jdbc.core.convert.DefaultJdbcTypeFactory;
42+
import org.springframework.data.jdbc.core.convert.IdGeneratingEntityCallback;
43+
import org.springframework.data.jdbc.core.convert.JdbcConverter;
44+
import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;
45+
import org.springframework.data.jdbc.core.convert.MappingJdbcConverter;
46+
import org.springframework.data.jdbc.core.convert.QueryMappingConfiguration;
47+
import org.springframework.data.jdbc.core.convert.RelationResolver;
48+
import org.springframework.data.jdbc.core.dialect.DialectResolver;
4049
import org.springframework.data.jdbc.core.dialect.JdbcArrayColumns;
4150
import org.springframework.data.jdbc.core.dialect.JdbcDialect;
4251
import org.springframework.data.jdbc.core.mapping.JdbcMappingContext;
4352
import org.springframework.data.jdbc.core.mapping.JdbcSimpleTypes;
44-
import org.springframework.data.jdbc.dialect.DialectResolver;
4553
import org.springframework.data.mapping.model.SimpleTypeHolder;
4654
import org.springframework.data.relational.RelationalManagedTypes;
4755
import org.springframework.data.relational.core.conversion.RelationalConverter;
@@ -52,7 +60,6 @@
5260
import org.springframework.data.util.TypeScanner;
5361
import org.springframework.jdbc.core.JdbcTemplate;
5462
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
55-
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
5663
import org.springframework.util.StringUtils;
5764

5865
/**
@@ -153,16 +160,13 @@ public IdGeneratingEntityCallback idGeneratingBeforeSaveCallback(JdbcMappingCont
153160
public JdbcConverter jdbcConverter(JdbcMappingContext mappingContext, NamedParameterJdbcOperations operations,
154161
@Lazy RelationResolver relationResolver, JdbcCustomConversions conversions, Dialect dialect) {
155162

156-
org.springframework.data.jdbc.core.dialect.JdbcArrayColumns arrayColumns = dialect instanceof JdbcDialect jd
157-
? jd.getArraySupport()
158-
: JdbcArrayColumns.DefaultSupport.INSTANCE;
163+
JdbcArrayColumns arrayColumns = JdbcDialect.getArraySupport(dialect);
159164
DefaultJdbcTypeFactory jdbcTypeFactory = new DefaultJdbcTypeFactory(operations.getJdbcOperations(), arrayColumns);
160165

161166
MappingJdbcConverter mappingJdbcConverter = new MappingJdbcConverter(mappingContext, relationResolver, conversions,
162167
jdbcTypeFactory);
163168

164-
if (operations instanceof NamedParameterJdbcTemplate namedParameterJdbcTemplate
165-
&& namedParameterJdbcTemplate.getJdbcOperations() instanceof JdbcTemplate jdbcTemplate) {
169+
if (operations.getJdbcOperations() instanceof JdbcTemplate jdbcTemplate) {
166170
mappingJdbcConverter.setExceptionTranslator(jdbcTemplate.getExceptionTranslator());
167171
}
168172

@@ -180,21 +184,17 @@ public JdbcConverter jdbcConverter(JdbcMappingContext mappingContext, NamedParam
180184
@Bean
181185
public JdbcCustomConversions jdbcCustomConversions() {
182186

183-
try {
184-
185-
Dialect dialect = applicationContext.getBean(Dialect.class);
186-
SimpleTypeHolder simpleTypeHolder = dialect.simpleTypes().isEmpty() ? JdbcSimpleTypes.HOLDER
187-
: new SimpleTypeHolder(dialect.simpleTypes(), JdbcSimpleTypes.HOLDER);
188-
189-
return new JdbcCustomConversions(
190-
CustomConversions.StoreConversions.of(simpleTypeHolder, storeConverters(dialect)), userConverters());
191-
192-
} catch (NoSuchBeanDefinitionException exception) {
193-
194-
LOG.warn("No dialect found; CustomConversions will be configured without dialect specific conversions");
187+
Dialect dialect = applicationContext.getBeanProvider(Dialect.class).getIfAvailable();
195188

189+
if (dialect == null) {
190+
LOG.warn("No dialect found; CustomConversions will be configured without dialect-specific types.");
196191
return new JdbcCustomConversions();
197192
}
193+
194+
SimpleTypeHolder simpleTypeHolder = new SimpleTypeHolder(dialect.simpleTypes(), JdbcSimpleTypes.HOLDER);
195+
196+
return new JdbcCustomConversions(CustomConversions.StoreConversions.of(simpleTypeHolder, storeConverters(dialect)),
197+
userConverters());
198198
}
199199

200200
protected List<?> userConverters() {
@@ -221,7 +221,6 @@ private List<Object> storeConverters(Dialect dialect) {
221221
@Bean
222222
public JdbcAggregateTemplate jdbcAggregateTemplate(ApplicationContext applicationContext,
223223
JdbcMappingContext mappingContext, JdbcConverter converter, DataAccessStrategy dataAccessStrategy) {
224-
225224
return new JdbcAggregateTemplate(applicationContext, mappingContext, converter, dataAccessStrategy);
226225
}
227226

@@ -235,13 +234,7 @@ public JdbcAggregateTemplate jdbcAggregateTemplate(ApplicationContext applicatio
235234
@Bean
236235
public DataAccessStrategy dataAccessStrategyBean(NamedParameterJdbcOperations operations, JdbcConverter jdbcConverter,
237236
JdbcMappingContext context, Dialect dialect) {
238-
239-
SqlGeneratorSource sqlGeneratorSource = new SqlGeneratorSource(context, jdbcConverter, dialect);
240-
DataAccessStrategyFactory factory = new DataAccessStrategyFactory(sqlGeneratorSource, jdbcConverter, operations,
241-
new SqlParametersFactory(context, jdbcConverter), new InsertStrategyFactory(operations, dialect),
242-
this.queryMappingConfiguration);
243-
244-
return factory.create();
237+
return new DataAccessStrategyFactory(jdbcConverter, operations, dialect, this.queryMappingConfiguration).create();
245238
}
246239

247240
/**

‎spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/support/JdbcRepositoryFactoryBean.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,8 @@
2525
import org.springframework.data.jdbc.core.JdbcAggregateOperations;
2626
import org.springframework.data.jdbc.core.convert.DataAccessStrategy;
2727
import org.springframework.data.jdbc.core.convert.DataAccessStrategyFactory;
28-
import org.springframework.data.jdbc.core.convert.InsertStrategyFactory;
2928
import org.springframework.data.jdbc.core.convert.JdbcConverter;
3029
import org.springframework.data.jdbc.core.convert.QueryMappingConfiguration;
31-
import org.springframework.data.jdbc.core.convert.SqlGeneratorSource;
32-
import org.springframework.data.jdbc.core.convert.SqlParametersFactory;
3330
import org.springframework.data.mapping.callback.EntityCallbacks;
3431
import org.springframework.data.relational.core.dialect.Dialect;
3532
import org.springframework.data.relational.core.mapping.RelationalMappingContext;
@@ -259,7 +256,7 @@ public void afterPropertiesSet() {
259256

260257
Assert.state(this.dialect != null, "Dialect must not be null");
261258

262-
DataAccessStrategyFactory factory = getDataAccessStrategyFactory(this.mappingContext, this.converter,
259+
DataAccessStrategyFactory factory = getDataAccessStrategyFactory(this.converter,
263260
this.dialect, this.jdbcOperations, this.queryMappingConfiguration);
264261

265262
this.dataAccessStrategy = factory.create();
@@ -270,15 +267,12 @@ public void afterPropertiesSet() {
270267
super.afterPropertiesSet();
271268
}
272269

273-
private static DataAccessStrategyFactory getDataAccessStrategyFactory(RelationalMappingContext mappingContext,
274-
JdbcConverter converter, Dialect dialect, NamedParameterJdbcOperations operations,
270+
private static DataAccessStrategyFactory getDataAccessStrategyFactory(JdbcConverter converter, Dialect dialect,
271+
NamedParameterJdbcOperations operations,
275272
QueryMappingConfiguration queryMapping) {
276273

277-
SqlGeneratorSource source = new SqlGeneratorSource(mappingContext, converter, dialect);
278-
SqlParametersFactory spf = new SqlParametersFactory(mappingContext, converter);
279-
InsertStrategyFactory isf = new InsertStrategyFactory(operations, dialect);
280274

281-
return new DataAccessStrategyFactory(source, converter, operations, spf, isf, queryMapping);
275+
return new DataAccessStrategyFactory(converter, operations, dialect, queryMapping);
282276
}
283277

284278
}

‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/EnableJdbcRepositoriesIntegrationTests.java

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,14 @@
3636
import org.springframework.data.jdbc.core.JdbcAggregateTemplate;
3737
import org.springframework.data.jdbc.core.convert.DataAccessStrategy;
3838
import org.springframework.data.jdbc.core.convert.DataAccessStrategyFactory;
39-
import org.springframework.data.jdbc.core.convert.InsertStrategyFactory;
4039
import org.springframework.data.jdbc.core.convert.JdbcConverter;
4140
import org.springframework.data.jdbc.core.convert.QueryMappingConfiguration;
42-
import org.springframework.data.jdbc.core.convert.SqlGeneratorSource;
43-
import org.springframework.data.jdbc.core.convert.SqlParametersFactory;
44-
import org.springframework.data.jdbc.dialect.DialectResolver;
41+
import org.springframework.data.jdbc.core.dialect.DialectResolver;
4542
import org.springframework.data.jdbc.repository.support.JdbcRepositoryFactoryBean;
4643
import org.springframework.data.jdbc.testing.TestClass;
4744
import org.springframework.data.jdbc.testing.TestConfiguration;
4845
import org.springframework.data.mapping.PersistentEntity;
4946
import org.springframework.data.relational.core.dialect.Dialect;
50-
import org.springframework.data.relational.core.mapping.RelationalMappingContext;
5147
import org.springframework.data.repository.CrudRepository;
5248
import org.springframework.jdbc.core.RowMapper;
5349
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
@@ -208,10 +204,9 @@ NamedParameterJdbcOperations qualifierJdbcOperations(DataSource dataSource) {
208204

209205
@Bean("qualifierDataAccessStrategy")
210206
DataAccessStrategy qualifierDataAccessStrategy(
211-
@Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template,
212-
RelationalMappingContext context, JdbcConverter converter, Dialect dialect) {
213-
return new DataAccessStrategyFactory(new SqlGeneratorSource(context, converter, dialect), converter, template,
214-
new SqlParametersFactory(context, converter), new InsertStrategyFactory(template, dialect),
207+
@Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template, JdbcConverter converter,
208+
Dialect dialect) {
209+
return new DataAccessStrategyFactory(converter, template, dialect,
215210
QueryMappingConfiguration.EMPTY).create();
216211
}
217212

@@ -248,10 +243,8 @@ NamedParameterJdbcOperations qualifierJdbcOperations(DataSource dataSource) {
248243
@Bean("qualifierDataAccessStrategy")
249244
DataAccessStrategy qualifierDataAccessStrategy(
250245
@Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template,
251-
RelationalMappingContext context, JdbcConverter converter, Dialect dialect) {
252-
return new DataAccessStrategyFactory(new SqlGeneratorSource(context, converter, dialect), converter, template,
253-
new SqlParametersFactory(context, converter), new InsertStrategyFactory(template, dialect),
254-
QueryMappingConfiguration.EMPTY).create();
246+
JdbcConverter converter, Dialect dialect) {
247+
return new DataAccessStrategyFactory(converter, template, dialect, QueryMappingConfiguration.EMPTY).create();
255248
}
256249

257250
@Bean

‎spring-data-jdbc/src/test/java/org/springframework/data/jdbc/testing/TestConfiguration.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,15 @@
3838
import org.springframework.data.convert.CustomConversions;
3939
import org.springframework.data.jdbc.core.JdbcAggregateOperations;
4040
import org.springframework.data.jdbc.core.JdbcAggregateTemplate;
41-
import org.springframework.data.jdbc.core.convert.*;
41+
import org.springframework.data.jdbc.core.convert.DataAccessStrategy;
42+
import org.springframework.data.jdbc.core.convert.DataAccessStrategyFactory;
43+
import org.springframework.data.jdbc.core.convert.DefaultJdbcTypeFactory;
44+
import org.springframework.data.jdbc.core.convert.IdGeneratingEntityCallback;
45+
import org.springframework.data.jdbc.core.convert.JdbcConverter;
46+
import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;
47+
import org.springframework.data.jdbc.core.convert.MappingJdbcConverter;
48+
import org.springframework.data.jdbc.core.convert.QueryMappingConfiguration;
49+
import org.springframework.data.jdbc.core.convert.RelationResolver;
4250
import org.springframework.data.jdbc.core.dialect.DialectResolver;
4351
import org.springframework.data.jdbc.core.dialect.JdbcArrayColumns;
4452
import org.springframework.data.jdbc.core.dialect.JdbcDialect;
@@ -114,8 +122,7 @@ DataAccessStrategy defaultDataAccessStrategy(
114122
@Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template, RelationalMappingContext context,
115123
JdbcConverter converter, Dialect dialect, Optional<QueryMappingConfiguration> queryMappingConfiguration) {
116124

117-
return new DataAccessStrategyFactory(new SqlGeneratorSource(context, converter, dialect), converter, template,
118-
new SqlParametersFactory(context, converter), new InsertStrategyFactory(template, dialect),
125+
return new DataAccessStrategyFactory(converter, template, dialect,
119126
queryMappingConfiguration.orElse(QueryMappingConfiguration.EMPTY)).create();
120127
}
121128

@@ -165,9 +172,7 @@ JdbcConverter relationalConverter(RelationalMappingContext mappingContext, @Lazy
165172
CustomConversions conversions, @Qualifier("namedParameterJdbcTemplate") NamedParameterJdbcOperations template,
166173
Dialect dialect) {
167174

168-
org.springframework.data.jdbc.core.dialect.JdbcArrayColumns arrayColumns = dialect instanceof JdbcDialect
169-
? ((JdbcDialect) dialect).getArraySupport()
170-
: JdbcArrayColumns.DefaultSupport.INSTANCE;
175+
JdbcArrayColumns arrayColumns = JdbcDialect.getArraySupport(dialect);
171176

172177
return new MappingJdbcConverter( //
173178
mappingContext, //

‎spring-data-relational/src/main/java/org/springframework/data/relational/core/dialect/H2Dialect.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
*/
1616
package org.springframework.data.relational.core.dialect;
1717

18-
import java.util.Collections;
19-
import java.util.Set;
20-
2118
import org.springframework.data.relational.core.sql.IdentifierProcessing;
2219
import org.springframework.data.relational.core.sql.IdentifierProcessing.LetterCasing;
2320
import org.springframework.data.relational.core.sql.IdentifierProcessing.Quoting;
@@ -112,12 +109,6 @@ public IdentifierProcessing getIdentifierProcessing() {
112109
return IDENTIFIER_PROCESSING;
113110
}
114111

115-
@Override
116-
public Set<Class<?>> simpleTypes() {
117-
118-
return Collections.emptySet();
119-
}
120-
121112
@Override
122113
public boolean supportsSingleQueryLoading() {
123114
return false;

0 commit comments

Comments
 (0)