Skip to content

Commit eb509dd

Browse files
committed
Updated Spring Data based dependencies
Spring Batch 4.0 will be part of the Spring Boot 2.0 release and so to be compatible with Spring Data Kay, the dependencies have been upgraded and tests fixed. Resolves BATCH-2560
1 parent ee8c28d commit eb509dd

File tree

2 files changed

+25
-22
lines changed

2 files changed

+25
-22
lines changed

build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ allprojects {
5151
springVersion = project.hasProperty('springVersion') ? getProperty('springVersion') : springVersionDefault
5252
springRetryVersion = '1.1.3.RELEASE'
5353
springAmqpVersion = '1.5.6.RELEASE'
54-
springDataCommonsVersion = '1.11.5.RELEASE'
55-
springDataGemfireVersion = '1.7.5.RELEASE'
56-
springDataJpaVersion = '1.9.5.RELEASE'
57-
springDataMongodbVersion = '1.8.5.RELEASE'
54+
springDataCommonsVersion = '2.0.0.BUILD-SNAPSHOT'
55+
springDataGemfireVersion = '2.0.0.BUILD-SNAPSHOT'
56+
springDataJpaVersion = '2.0.0.BUILD-SNAPSHOT'
57+
springDataMongodbVersion = '2.0.0.BUILD-SNAPSHOT'
5858
springDataNeo4jVersion = '3.4.5.RELEASE'
59-
springDataNeo4j4Version = '4.1.3.RELEASE' //?
59+
springDataNeo4j4Version = '5.0.0.BUILD-SNAPSHOT' //?
6060
springIntegrationVersion = '5.0.0.BUILD-SNAPSHOT'
6161
springLdapVersion = '2.0.4.RELEASE'
6262

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/data/MongoItemReaderTests.java

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,20 @@
1515
*/
1616
package org.springframework.batch.item.data;
1717

18+
import java.util.ArrayList;
19+
import java.util.HashMap;
20+
import java.util.Map;
21+
1822
import org.junit.Before;
1923
import org.junit.Test;
2024
import org.mockito.ArgumentCaptor;
2125
import org.mockito.Mock;
2226
import org.mockito.MockitoAnnotations;
27+
2328
import org.springframework.data.domain.Sort;
2429
import org.springframework.data.mongodb.core.MongoOperations;
2530
import org.springframework.data.mongodb.core.query.Query;
2631

27-
import java.util.ArrayList;
28-
import java.util.HashMap;
29-
import java.util.Map;
30-
3132
import static org.junit.Assert.assertEquals;
3233
import static org.junit.Assert.assertFalse;
3334
import static org.junit.Assert.assertNull;
@@ -120,8 +121,8 @@ public void testBasicQueryFirstPage() {
120121
Query query = queryContainer.getValue();
121122
assertEquals(50, query.getLimit());
122123
assertEquals(0, query.getSkip());
123-
assertEquals("{ }", query.getQueryObject().toString());
124-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
124+
assertEquals("{ }", query.getQueryObject().toJson());
125+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
125126
}
126127

127128
@Test
@@ -137,8 +138,8 @@ public void testBasicQuerySecondPage() {
137138

138139
assertEquals(50, query.getLimit());
139140
assertEquals(100, query.getSkip());
140-
assertEquals("{ }", query.getQueryObject().toString());
141-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
141+
assertEquals("{ }", query.getQueryObject().toJson());
142+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
142143
assertNull(query.getFieldsObject());
143144
}
144145

@@ -154,9 +155,11 @@ public void testQueryWithFields() {
154155
Query query = queryContainer.getValue();
155156
assertEquals(50, query.getLimit());
156157
assertEquals(0, query.getSkip());
157-
assertEquals("{ }", query.getQueryObject().toString());
158-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
159-
assertEquals("{ \"name\" : 1 , \"age\" : 1 , \"_id\" : 0}", query.getFieldsObject().toString());
158+
assertEquals("{ }", query.getQueryObject().toJson());
159+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
160+
assertEquals(1, query.getFieldsObject().get("name"));
161+
assertEquals(1, query.getFieldsObject().get("age"));
162+
assertEquals(0, query.getFieldsObject().get("_id"));
160163
}
161164

162165
@Test
@@ -171,8 +174,8 @@ public void testQueryWithHint() {
171174
Query query = queryContainer.getValue();
172175
assertEquals(50, query.getLimit());
173176
assertEquals(0, query.getSkip());
174-
assertEquals("{ }", query.getQueryObject().toString());
175-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
177+
assertEquals("{ }", query.getQueryObject().toJson());
178+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
176179
assertEquals("{ $natural : 1}", query.getHint());
177180
}
178181

@@ -193,8 +196,8 @@ public void testQueryWithParameters() {
193196
Query query = queryContainer.getValue();
194197
assertEquals(50, query.getLimit());
195198
assertEquals(0, query.getSkip());
196-
assertEquals("{ \"name\" : \"foo\"}", query.getQueryObject().toString());
197-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
199+
assertEquals("{ \"name\" : \"foo\" }", query.getQueryObject().toJson());
200+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
198201
}
199202

200203
@SuppressWarnings("serial")
@@ -216,8 +219,8 @@ public void testQueryWithCollection() {
216219
Query query = queryContainer.getValue();
217220
assertEquals(50, query.getLimit());
218221
assertEquals(0, query.getSkip());
219-
assertEquals("{ \"name\" : \"foo\"}", query.getQueryObject().toString());
220-
assertEquals("{ \"name\" : -1}", query.getSortObject().toString());
222+
assertEquals("{ \"name\" : \"foo\" }", query.getQueryObject().toJson());
223+
assertEquals("{ \"name\" : -1 }", query.getSortObject().toJson());
221224
assertEquals("collection", collectionContainer.getValue());
222225
}
223226
}

0 commit comments

Comments
 (0)