Skip to content

Commit 7ba73d8

Browse files
Benoit Dupontfmbenhassine
authored andcommitted
Fix dead link to Github in contribution guide
1 parent bcc4665 commit 7ba73d8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Please refer back to this document as a checklist before issuing any pull reques
77

88
## Understand the basics
99

10-
Not sure what a *pull request* is, or how to submit one? Take a look at GitHub's excellent [help documentation][] first.
10+
Not sure what a *pull request* is, or how to submit one? Take a look at the excellent [GitHub help documentation][] first.
1111

1212
## Search Github issues first; create an issue if necessary
1313

@@ -47,7 +47,7 @@ _you should see branches on origin as well as upstream, including 'master'_
4747
* When ready to resolve an issue or to collaborate with others, you can push your branch to origin (your fork), e.g.: `git push origin BATCH-123`
4848
* If you want to collaborate with another contributor, have them fork your repository (add it as a remote) and `git fetch <your-username>` to grab your branch. Alternatively, they can use `git fetch --all` to sync their local state with all of their remotes.
4949
* If you grant that collaborator push access to your repository, they can even apply their changes to your branch.
50-
* When ready for your contribution to be reviewed for potential inclusion in the master branch of the canonical *spring-batch* repository (what you know as 'upstream'), issue a pull request to the *spring-projects* repository (for more detail, see [https://help.github.com/send-pull-requests/](https://help.github.com/send-pull-requests/)).
50+
* When ready for your contribution to be reviewed for potential inclusion in the master branch of the canonical *spring-batch* repository (what you know as 'upstream'), issue a pull request to the *spring-projects* repository (for more detail, see [GitHub help documentation][]).
5151
* The project lead may merge your changes into the upstream master branch as-is, he may keep the pull request open yet add a comment about something that should be modified, or he might reject the pull request by closing it.
5252
* A prerequisite for any pull request is that it will be cleanly merge-able with the upstream master's current state. **This is the responsibility of any contributor.** If your pull request cannot be applied cleanly, the project lead will most likely add a comment requesting that you make it merge-able. For a full explanation, see the Pro Git section on rebasing: [https://git-scm.com/book/en/v2/Git-Branching-Rebasing](https://git-scm.com/book/en/v2/Git-Branching-Rebasing). As stated there: "> Often, you’ll do this to make sure your commits apply cleanly on a remote branch — perhaps in a project to which you’re trying to contribute but that you don’t maintain."
5353

@@ -188,6 +188,6 @@ See the [checking out and building][] section of the README for instructions. Ma
188188

189189
Add a comment to the associated Github issue(s) linking to your new pull request.
190190

191-
[help documentation]: https://help.github.com/send-pull-requests
191+
[GitHub help documentation]: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests
192192
[Github issues]: https://github.com/spring-projects/spring-batch/issues
193193
[checking out and building]: https://github.com/spring-projects/spring-batch#building-from-source

0 commit comments

Comments
 (0)