Add repro project for SPR-13983

Author: sdeleuze

SPR-13983/README.md

@@ -0,0 +1,9 @@
+To reproduce the issue:
+ - http://localhost:8080/json/test : output OK {"result":true}
+ - http://localhost:8080/html/test
+ - http://localhost:8080/json/test : output NOK {"result":true}{"result":true}
+ 
+The issue is reproducible only when RequestMappingHandlerAdapter.setSynchronizeOnSession(true)
+is invoked (cf. SynchronizeOnSessionPostProcessor) with Spring Framework 4.2.5.
+
+Works fine with Spring Framework 4.2.4.

SPR-13983/pom.xml

@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<groupId>org.springframework.issues</groupId>
+	<artifactId>SPR-13983</artifactId>
+	<version>0.0.1-SNAPSHOT</version>
+	<packaging>jar</packaging>
+
+	<name>Spring MVC Issue Reproduction Project for issue SPR-13983</name>
+
+	<parent>
+		<groupId>org.springframework.boot</groupId>
+		<artifactId>spring-boot-starter-parent</artifactId>
+		<version>1.3.3.RELEASE</version>
+		<relativePath/> <!-- lookup parent from repository -->
+	</parent>
+
+	<properties>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+		<java.version>1.8</java.version>
+		<spring.version>4.2.5.RELEASE</spring.version>
+		<jackson.version>2.4.2</jackson.version>
+	</properties>
+
+	<dependencies>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-web</artifactId>
+		</dependency>
+
+		<dependency>
+			<groupId>org.apache.tomcat.embed</groupId>
+			<artifactId>tomcat-embed-jasper</artifactId>
+			<scope>compile</scope>
+		</dependency>
+
+		<dependency>
+			<groupId>javax.servlet</groupId>
+			<artifactId>jstl</artifactId>
+		</dependency>
+
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-test</artifactId>
+			<scope>test</scope>
+		</dependency>
+	</dependencies>
+	
+	<build>
+		<plugins>
+			<plugin>
+				<groupId>org.springframework.boot</groupId>
+				<artifactId>spring-boot-maven-plugin</artifactId>
+			</plugin>
+		</plugins>
+	</build>
+	
+
+</project>

SPR-13983/src/main/java/com/example/DemoApplication.java

@@ -0,0 +1,19 @@
+package com.example;
+
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.boot.builder.SpringApplicationBuilder;
+import org.springframework.boot.context.web.SpringBootServletInitializer;
+
+@SpringBootApplication
+public class DemoApplication extends SpringBootServletInitializer {
+
+	@Override
+	protected SpringApplicationBuilder configure(SpringApplicationBuilder application) {
+		return application.sources(DemoApplication.class);
+	}
+
+	public static void main(String[] args) {
+		SpringApplication.run(DemoApplication.class, args);
+	}
+}

SPR-13983/src/main/java/com/example/HtmlController.java

@@ -0,0 +1,15 @@
+package com.example;
+
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.servlet.ModelAndView;
+
+@Controller
+public class HtmlController {
+
+	@RequestMapping(value = "/html/test")
+	public ModelAndView test1() {
+		return new ModelAndView("test");
+	}
+
+}

SPR-13983/src/main/java/com/example/JsonTestController.java

@@ -0,0 +1,34 @@
+package com.example;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.springframework.http.MediaType;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+public class JsonTestController {
+
+	@RequestMapping(value = "/json/test", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
+	public Map<String, Object> test() {
+		Map<String, Object> map = new LinkedHashMap<>();
+		map.put("result", Boolean.TRUE);
+		return map;
+	}
+
+	@RequestMapping(value = "/json/test2", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
+	public Map<String, Object> test2() {
+		Map<String, Object> map = new LinkedHashMap<>();
+		map.put("result", Boolean.TRUE);
+		return map;
+	}
+
+	@RequestMapping(value = "/json/test3", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
+	public Map<String, Object> test3() {
+		Map<String, Object> map = new LinkedHashMap<>();
+		map.put("result", Boolean.TRUE);
+		return map;
+	}
+
+}

SPR-13983/src/main/java/com/example/SynchronizeOnSessionPostProcessor.java

@@ -0,0 +1,26 @@
+package com.example;
+
+import org.springframework.beans.BeansException;
+import org.springframework.beans.factory.config.BeanPostProcessor;
+import org.springframework.stereotype.Component;
+import org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter;
+
+@Component
+public class SynchronizeOnSessionPostProcessor implements BeanPostProcessor {
+
+	@Override
+	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
+		return bean;
+	}
+
+	@Override
+	public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
+		// do synchronize each http request
+		if (bean instanceof RequestMappingHandlerAdapter) {
+			RequestMappingHandlerAdapter adapter = (RequestMappingHandlerAdapter) bean;
+			adapter.setSynchronizeOnSession(true);
+		}
+		return bean;
+	}
+
+}

SPR-13983/src/main/resources/application.properties

@@ -0,0 +1,3 @@
+spring.mvc.view.prefix=/WEB-INF/jsp/
+spring.mvc.view.suffix=.jsp
+logging.level.org.springframework.web=DEBUG

SPR-13983/src/main/webapp/WEB-INF/jsp/test.jsp

@@ -0,0 +1 @@
+test