Support dynamic class constant fetch available in PHP 8.3

https://wiki.php.net/rfc/dynamic_class_constant_fetch

Fix #241

Author: spaze

.github/workflows/php.yml

@@ -31,6 +31,8 @@ jobs:
             run: composer lint
           - php-version: "8.1"
             run: composer lint
+          - php-version: "8.2"
+            run: composer lint
         include:
           - php-version: "7.2"
             run: composer lint-7.x
@@ -42,6 +44,8 @@ jobs:
             run: composer lint-8.0
           - php-version: "8.1"
             run: composer lint-8.1
+          - php-version: "8.2"
+            run: composer lint-8.2
 
     steps:
     - uses: actions/checkout@v4

composer.json

@@ -40,9 +40,10 @@
 	},
 	"scripts": {
 		"lint": "vendor/bin/parallel-lint --colors src/ tests/",
-		"lint-7.x": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/TypesEverywhere.php --exclude tests/src/AttributesEverywhere.php --exclude tests/src/disallowed/functionCallsNamedParams.php --exclude tests/src/disallowed-allow/functionCallsNamedParams.php --exclude tests/src/disallowed/attributeUsages.php --exclude tests/src/disallowed-allow/attributeUsages.php",
-		"lint-8.0": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/TypesEverywhere.php --exclude tests/src/AttributesEverywhere.php",
-		"lint-8.1": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/AttributesEverywhere.php",
+		"lint-7.x": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/TypesEverywhere.php --exclude tests/src/AttributesEverywhere.php --exclude tests/src/disallowed/functionCallsNamedParams.php --exclude tests/src/disallowed-allow/functionCallsNamedParams.php --exclude tests/src/disallowed/attributeUsages.php --exclude tests/src/disallowed-allow/attributeUsages.php --exclude tests/src/disallowed/constantDynamicUsages.php --exclude tests/src/disallowed-allow/constantDynamicUsages.php",
+		"lint-8.0": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/TypesEverywhere.php --exclude tests/src/AttributesEverywhere.php --exclude tests/src/disallowed/constantDynamicUsages.php --exclude tests/src/disallowed-allow/constantDynamicUsages.php",
+		"lint-8.1": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/AttributesEverywhere.php --exclude tests/src/disallowed/constantDynamicUsages.php --exclude tests/src/disallowed-allow/constantDynamicUsages.php",
+		"lint-8.2": "vendor/bin/parallel-lint --colors src/ tests/ --exclude tests/src/disallowed/constantDynamicUsages.php --exclude tests/src/disallowed-allow/constantDynamicUsages.php",
 		"lint-neon": "vendor/bin/neon-lint .",
 		"phpcs": "vendor/bin/phpcs src/ tests/",
 		"cs-fix": "vendor/bin/phpcbf src/ tests/",

src/Usages/ClassConstantUsages.php

@@ -5,13 +5,15 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use Spaze\PHPStan\Rules\Disallowed\DisallowedConstant;
 use Spaze\PHPStan\Rules\Disallowed\DisallowedConstantFactory;
@@ -80,17 +82,38 @@ public function processNode(Node $node, Scope $scope): array
 		if (!($node instanceof ClassConstFetch)) {
 			throw new ShouldNotHappenException(sprintf('$node should be %s but is %s', ClassConstFetch::class, get_class($node)));
 		}
-		if (!($node->name instanceof Identifier)) {
-			throw new ShouldNotHappenException(sprintf('$node->name should be %s but is %s', Identifier::class, get_class($node->name)));
+		if ($node->name instanceof Identifier) {
+			return $this->getConstantRuleErrors($scope, (string)$node->name, $this->typeResolver->getType($node->class, $scope));
 		}
-		$constant = (string)$node->name;
-		$type = $this->typeResolver->getType($node->class, $scope);
-		$usedOnType = $type->getObjectTypeOrClassStringObjectType();
+		if ($node->name instanceof Variable) {
+			$type = $scope->getType($node->name);
+			$errors = [];
+			foreach ($type->getConstantStrings() as $constantString) {
+				$errors = array_merge(
+					$errors,
+					$this->getConstantRuleErrors($scope, $constantString->getValue(), $this->typeResolver->getType($node->class, $scope))
+				);
+			}
+			return $errors;
+		}
+		throw new ShouldNotHappenException(sprintf('$node->name should be %s but is %s', Identifier::class, get_class($node->name)));
+	}
 
+
+	/**
+	 * @param Scope $scope
+	 * @param string $constant
+	 * @param Type $type
+	 * @return list<RuleError>
+	 * @throws ShouldNotHappenException
+	 */
+	private function getConstantRuleErrors(Scope $scope, string $constant, Type $type): array
+	{
 		if (strtolower($constant) === 'class') {
 			return [];
 		}
 
+		$usedOnType = $type->getObjectTypeOrClassStringObjectType();
 		$displayName = $usedOnType->getObjectClassNames() ? $this->getFullyQualified($usedOnType->getObjectClassNames(), $constant) : null;
 		if ($usedOnType->getConstantStrings()) {
 			$classNames = array_map(

tests/Usages/ClassConstantUsagesTest.php

@@ -141,6 +141,27 @@ public function testRule(): void
 	}
 
 
+	public function testRuleDynamicClassConstantFetch(): void
+	{
+		// Based on the configuration above, in this file:
+		$this->analyse([__DIR__ . '/../src/disallowed/constantDynamicUsages.php'], [
+			[
+				'Using Waldo\Quux\Blade::RUNNER is forbidden, not a replicant.',
+				8,
+			],
+			[
+				'Using Waldo\Quux\Blade::DECKARD is forbidden, maybe a replicant.',
+				10,
+			],
+			[
+				'Using Waldo\Quux\Blade::RUNNER is forbidden, not a replicant.',
+				10,
+			],
+		]);
+		$this->analyse([__DIR__ . '/../src/disallowed-allow/constantDynamicUsages.php'], []);
+	}
+
+
 	public static function getAdditionalConfigFiles(): array
 	{
 		return [

tests/src/Blade.php

@@ -12,6 +12,8 @@ class Blade
 
 	public const WESLEY = 'Snipes';
 
+	public const MOVIE = Blade::WESLEY;
+
 
 	public function runner(int $everything = 0, bool $yes = false, string $roland = '303'): void
 	{

tests/src/disallowed-allow/constantDynamicUsages.php

@@ -0,0 +1,10 @@
+<?php
+declare(strict_types = 1);
+
+use Waldo\Quux\Blade;
+
+// allowed by path
+$kind = 'RUNNER';
+echo Blade::{$kind};
+/** @var 'DECKARD'|'MOVIE'|'RUNNER' $kind2 */
+echo Blade::{$kind2};

tests/src/disallowed/constantDynamicUsages.php

@@ -0,0 +1,10 @@
+<?php
+declare(strict_types = 1);
+
+use Waldo\Quux\Blade;
+
+// disallowed
+$kind = 'RUNNER';
+echo Blade::{$kind};
+/** @var 'DECKARD'|'MOVIE'|'RUNNER' $kind2 */
+echo Blade::{$kind2};