Skip to content

Commit 998b764

Browse files
authored
Merge pull request #275 from Edouard-chin/ec-boolean-pragma-fix
Fix `get_boolean_pragma` comparison:
2 parents cc3fb2e + 1d67e24 commit 998b764

File tree

2 files changed

+25
-3
lines changed

2 files changed

+25
-3
lines changed

lib/sqlite3/pragmas.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Pragmas
1111

1212
# Returns +true+ or +false+ depending on the value of the named pragma.
1313
def get_boolean_pragma( name )
14-
get_first_value( "PRAGMA #{name}" ) != "0"
14+
get_first_value( "PRAGMA #{name}" ) != 0
1515
end
1616

1717
# Sets the given pragma to the given boolean value. The value itself
@@ -260,7 +260,7 @@ def full_column_names
260260
def full_column_names=( mode )
261261
set_boolean_pragma "full_column_names", mode
262262
end
263-
263+
264264
def fullfsync
265265
get_boolean_pragma "fullfsync"
266266
end
@@ -356,7 +356,7 @@ def page_size=( size )
356356
def parser_trace=( mode )
357357
set_boolean_pragma "parser_trace", mode
358358
end
359-
359+
360360
def query_only
361361
get_boolean_pragma "query_only"
362362
end

test/test_pragmas.rb

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
require 'helper'
2+
3+
module SQLite3
4+
class TestPragmas < SQLite3::TestCase
5+
def setup
6+
super
7+
@db = SQLite3::Database.new(":memory:")
8+
end
9+
10+
def test_get_boolean_pragma
11+
refute(@db.get_boolean_pragma("read_uncommitted"))
12+
end
13+
14+
def test_set_boolean_pragma
15+
@db.set_boolean_pragma("read_uncommitted", 1)
16+
17+
assert(@db.get_boolean_pragma("read_uncommitted"))
18+
ensure
19+
@db.set_boolean_pragma("read_uncommitted", 0)
20+
end
21+
end
22+
end

0 commit comments

Comments
 (0)