backport: fix(css-selector): default XML namespace should not be applied to wildcard (#3414)

Backport of #3413 to
v1.18.x

Author: flavorjones

.github/workflows/ci.yml

@@ -97,7 +97,7 @@ jobs:
     outputs:
       # these are usually the same, but are different once we get to ruby release candidates
       setup_ruby: "['3.1', '3.2', '3.3', '3.4']"
-      setup_ruby_win: "['3.1', '3.2', '3.3', 'head']"
+      setup_ruby_win: "['3.1', '3.2', '3.3', '3.4']"
       image_tag: "['3.1', '3.2', '3.3', '3.4']"
     runs-on: ubuntu-latest
     steps:

Gemfile

@@ -33,8 +33,6 @@ end
 # If Psych doesn't build, you can disable this group locally by running
 # `bundle config set --local without rdoc`
 # Then re-run `bundle install`.
-unless RUBY_PLATFORM == "java" # see #3391 and https://github.com/jruby/jruby/issues/7262
-  group :rdoc do
-    gem "rdoc", "6.10.0"
-  end
+group :rdoc do
+  gem "rdoc", "6.10.0" unless RUBY_PLATFORM == "java" || ENV["CI"]
 end

lib/nokogiri/css/xpath_visitor.rb

@@ -283,7 +283,8 @@ def visit_element_name(node)
           else
             node.value.join(":")
           end
-        elsif @namespaces&.key?("xmlns") # apply the default namespace if it's declared
+        elsif node.value.first != "*" && @namespaces&.key?("xmlns")
+          # apply the default namespace (if one is present) to a non-wildcard selector
           "xmlns:#{node.value.first}"
         else
           node.value.first

scripts/test-gem-install

@@ -28,6 +28,7 @@ popd
 # 2.3.21 because https://github.com/rubygems/rubygems/issues/5914
 # 2.3.22 because https://github.com/rubygems/rubygems/issues/5940
 gem install bundler -v "~> 2.2, != 2.3.21, != 2.3.22"
+bundle config set --local without rdoc
 bundle install --local || bundle install
 
 rm -rf lib ext # ensure we don't use the local files

test/css/test_xpath_visitor.rb

@@ -143,53 +143,68 @@ def visit_pseudo_class_aaron(node)
       )
     end
 
-    it "# id" do
-      assert_xpath("//*[@id='foo']", "#foo")
-      assert_xpath("//*[@id='escape:needed,']", "#escape\\:needed\\,")
-      assert_xpath("//*[@id='escape:needed,']", '#escape\3Aneeded\,')
-      assert_xpath("//*[@id='escape:needed,']", '#escape\3A needed\2C')
-      assert_xpath("//*[@id='escape:needed']", '#escape\00003Aneeded')
-    end
-
-    describe "attribute" do
-      it "basic mechanics" do
-        assert_xpath("//h1[@a='Tender Lovemaking']", "h1[a='Tender Lovemaking']")
-        assert_xpath("//h1[@a]", "h1[a]")
-        assert_xpath(%q{//h1[@a='gnewline\n']}, "h1[a='\\gnew\\\nline\\\\n']")
-        assert_xpath("//h1[@a='test']", %q{h1[a=\te\st]})
-      end
-
-      it "parses leading @ (extended-syntax)" do
-        assert_xpath("//a[@id='Boing']", "a[@id='Boing']")
-        assert_xpath("//a[@id='Boing']", "a[@id = 'Boing']")
-        assert_xpath("//a[@id='Boing']//div", "a[@id='Boing'] div")
+    describe "namespaces" do
+      let(:ns) do
+        {
+          "xmlns" => "http://default.example.com/",
+          "hoge" => "http://hoge.example.com/",
+        }
       end
 
-      it "namespacing" do
+      it "basic mechanics" do
         assert_xpath("//a[@flavorjones:href]", "a[flavorjones|href]")
         assert_xpath("//a[@href]", "a[|href]")
         assert_xpath("//*[@flavorjones:href]", "*[flavorjones|href]")
+      end
 
-        ns = {
-          "xmlns" => "http://default.example.com/",
-          "hoge" => "http://hoge.example.com/",
-        }
-
-        # An intentionally-empty namespace means "don't use the default xmlns"
-        assert_equal(["//a"], Nokogiri::CSS.xpath_for("|a", ns: ns, cache: false))
-
-        # The default namespace is not applied to attributes (just elements)
+      it "default namespace is applied to elements but not attributes" do
         assert_equal(
           ["//xmlns:a[@class='bar']"],
           Nokogiri::CSS.xpath_for("a[class='bar']", ns: ns, cache: false),
         )
+      end
 
-        # We can explicitly apply a namespace to an attribue
+      it "default namespace is not applied to wildcard selectors" do
+        assert_equal(
+          ["//xmlns:a//*"],
+          Nokogiri::CSS.xpath_for("a *", ns: ns, cache: false),
+        )
+      end
+
+      it "intentionally-empty namespace omits the default xmlns" do
+        # An intentionally-empty namespace
+        assert_equal(["//a"], Nokogiri::CSS.xpath_for("|a", ns: ns, cache: false))
+      end
+
+      it "explicit namespaces are applied to attributes" do
         assert_equal(
           ["//xmlns:a[@hoge:class='bar']"],
           Nokogiri::CSS.xpath_for("a[hoge|class='bar']", ns: ns, cache: false),
         )
       end
+    end
+
+    describe "attribute" do
+      it "basic mechanics" do
+        assert_xpath("//h1[@a='Tender Lovemaking']", "h1[a='Tender Lovemaking']")
+        assert_xpath("//h1[@a]", "h1[a]")
+        assert_xpath(%q{//h1[@a='gnewline\n']}, "h1[a='\\gnew\\\nline\\\\n']")
+        assert_xpath("//h1[@a='test']", %q{h1[a=\te\st]})
+      end
+
+      it "#id escaping" do
+        assert_xpath("//*[@id='foo']", "#foo")
+        assert_xpath("//*[@id='escape:needed,']", "#escape\\:needed\\,")
+        assert_xpath("//*[@id='escape:needed,']", '#escape\3Aneeded\,')
+        assert_xpath("//*[@id='escape:needed,']", '#escape\3A needed\2C')
+        assert_xpath("//*[@id='escape:needed']", '#escape\00003Aneeded')
+      end
+
+      it "parses leading @ (extended-syntax)" do
+        assert_xpath("//a[@id='Boing']", "a[@id='Boing']")
+        assert_xpath("//a[@id='Boing']", "a[@id = 'Boing']")
+        assert_xpath("//a[@id='Boing']//div", "a[@id='Boing'] div")
+      end
 
       it "rhs with quotes" do
         assert_xpath(%q{//h1[@a="'"]}, %q{h1[a="'"]})