update map/set constructor to match TypeScript's... mostly (#459)

Author: thetarnav

.changeset/green-needles-approve.md

@@ -0,0 +1,6 @@
+---
+"@solid-primitives/map": patch
+"@solid-primitives/set": patch
+---
+
+Update `ReactiveSet`/`ReactiveMap` constructors to allow passing any iterable as the initial value.

packages/map/src/index.ts

@@ -24,7 +24,7 @@ export class ReactiveMap<K, V> extends Map<K, V> {
   #keyTriggers = new TriggerCache<K | typeof $KEYS>();
   #valueTriggers = new TriggerCache<K>();
 
-  constructor(initial?: [K, V][]) {
+  constructor(initial?: Iterable<readonly [K, V]> | null) {
     super();
     if (initial) for (const v of initial) super.set(v[0], v[1]);
   }
@@ -127,7 +127,7 @@ export class ReactiveWeakMap<K extends object, V> extends WeakMap<K, V> {
   #keyTriggers = new TriggerCache<K>(WeakMap);
   #valueTriggers = new TriggerCache<K>(WeakMap);
 
-  constructor(initial?: [K, V][]) {
+  constructor(initial?: Iterable<readonly [K, V]> | null) {
     super();
     if (initial) for (const v of initial) super.set(v[0], v[1]);
   }

packages/set/src/index.ts

@@ -18,7 +18,7 @@ const $KEYS = Symbol("track-keys");
 export class ReactiveSet<T> extends Set<T> {
   #triggers = new TriggerCache<T | typeof $KEYS>();
 
-  constructor(values?: readonly T[] | null) {
+  constructor(values?: Iterable<T> | null) {
     super();
     if (values) for (const v of values) super.add(v);
   }
@@ -94,7 +94,7 @@ export class ReactiveSet<T> extends Set<T> {
 export class ReactiveWeakSet<T extends object> extends WeakSet<T> {
   #triggers = new TriggerCache<T>(WeakMap);
 
-  constructor(values?: readonly T[] | null) {
+  constructor(values?: Iterable<T> | null) {
     super();
     if (values) for (const v of values) super.add(v);
   }