Fix further cargo clippy --test warnings following rebase.

Author: svenski123

cli/src/checks.rs

@@ -97,10 +97,8 @@ mod tests {
         let mut mocks = HashMap::new();
         mocks.insert(RpcRequest::GetBalance, account_balance_response.clone());
         let rpc_client = RpcClient::new_mock_with_mocks("".to_string(), mocks);
-        assert_eq!(
-            check_account_for_fee(&rpc_client, &pubkey, &fee_calculator, &message0).unwrap(),
-            ()
-        );
+        check_account_for_fee(&rpc_client, &pubkey, &fee_calculator, &message0)
+            .expect("unexpected result");
 
         let mut mocks = HashMap::new();
         mocks.insert(RpcRequest::GetBalance, account_balance_response.clone());
@@ -128,16 +126,13 @@ mod tests {
         mocks.insert(RpcRequest::GetBalance, account_balance_response);
         let rpc_client = RpcClient::new_mock_with_mocks("".to_string(), mocks);
 
-        assert_eq!(
-            check_account_for_multiple_fees(
-                &rpc_client,
-                &pubkey,
-                &fee_calculator,
-                &[&message0, &message0]
-            )
-            .unwrap(),
-            ()
-        );
+        check_account_for_multiple_fees(
+            &rpc_client,
+            &pubkey,
+            &fee_calculator,
+            &[&message0, &message0],
+        )
+        .expect("unexpected result");
     }
 
     #[test]
@@ -194,19 +189,14 @@ mod tests {
     #[test]
     fn test_check_unique_pubkeys() {
         let pubkey0 = Pubkey::new_rand();
-        let pubkey_clone = pubkey0.clone();
+        let pubkey_clone = pubkey0;
         let pubkey1 = Pubkey::new_rand();
 
-        assert_eq!(
-            check_unique_pubkeys((&pubkey0, "foo".to_string()), (&pubkey1, "bar".to_string()))
-                .unwrap(),
-            ()
-        );
-        assert_eq!(
-            check_unique_pubkeys((&pubkey0, "foo".to_string()), (&pubkey1, "foo".to_string()))
-                .unwrap(),
-            ()
-        );
+        check_unique_pubkeys((&pubkey0, "foo".to_string()), (&pubkey1, "bar".to_string()))
+            .expect("unexpected result");
+        check_unique_pubkeys((&pubkey0, "foo".to_string()), (&pubkey1, "foo".to_string()))
+            .expect("unexpected result");
+
         assert!(check_unique_pubkeys(
             (&pubkey0, "foo".to_string()),
             (&pubkey_clone, "bar".to_string())

core/src/gossip_service.rs

@@ -343,7 +343,7 @@ mod tests {
         assert_eq!(met_criteria, true);
 
         let (met_criteria, _, _, _) = spy(
-            spy_ref.clone(),
+            spy_ref,
             None,
             Some(0),
             None,

remote-wallet/src/ledger.rs

@@ -575,7 +575,7 @@ mod tests {
 
     #[test]
     fn test_parse_status() {
-        assert_eq!(LedgerWallet::parse_status(APDU_SUCCESS_CODE).unwrap(), ());
+        LedgerWallet::parse_status(APDU_SUCCESS_CODE).expect("unexpected result");
         if let RemoteWalletError::LedgerError(err) = LedgerWallet::parse_status(0x6985).unwrap_err()
         {
             assert_eq!(err, LedgerError::UserCancel);

runtime/src/bank.rs

@@ -5825,6 +5825,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_check_point_value() {
         let (genesis_config, _) = create_genesis_config(500);
         let bank = Arc::new(Bank::new(&genesis_config));