Skip to content

Commit d10d4a3

Browse files
amaliujiadongjoon-hyun
authored andcommitted
[SPARK-42876][SQL] DataType's physicalDataType should be private[sql]
### What changes were proposed in this pull request? `physicalDataType` should not be a public API but be private[sql]. ### Why are the changes needed? This is to limit API scope to not expose unnecessary API to be public. ### Does this PR introduce _any_ user-facing change? No since we have not released Spark 3.4.0 yet. ### How was this patch tested? N/A Closes apache#40499 from amaliujia/change_scope_of_physical_data_type. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit c9a530e) Signed-off-by: Wenchen Fan <[email protected]>
1 parent 9c68e84 commit d10d4a3

23 files changed

+24
-23
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/types/ArrayType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ case class ArrayType(elementType: DataType, containsNull: Boolean) extends DataT
9191
*/
9292
override def defaultSize: Int = 1 * elementType.defaultSize
9393

94-
override def physicalDataType: PhysicalDataType =
94+
private[sql] override def physicalDataType: PhysicalDataType =
9595
PhysicalArrayType(elementType, containsNull)
9696

9797
override def simpleString: String = s"array<${elementType.simpleString}>"

sql/catalyst/src/main/scala/org/apache/spark/sql/types/BinaryType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class BinaryType private() extends AtomicType {
4545
*/
4646
override def defaultSize: Int = 100
4747

48-
override def physicalDataType: PhysicalDataType = PhysicalBinaryType
48+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalBinaryType
4949

5050
private[spark] override def asNullable: BinaryType = this
5151
}

sql/catalyst/src/main/scala/org/apache/spark/sql/types/BooleanType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class BooleanType private() extends AtomicType {
4242
*/
4343
override def defaultSize: Int = 1
4444

45-
override def physicalDataType: PhysicalDataType = PhysicalBooleanType
45+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalBooleanType
4646

4747
private[spark] override def asNullable: BooleanType = this
4848
}

sql/catalyst/src/main/scala/org/apache/spark/sql/types/ByteType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class ByteType private() extends IntegralType {
4545
*/
4646
override def defaultSize: Int = 1
4747

48-
override def physicalDataType: PhysicalDataType = PhysicalByteType
48+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalByteType
4949

5050
override def simpleString: String = "tinyint"
5151

sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class CalendarIntervalType private() extends DataType {
3838

3939
override def defaultSize: Int = 16
4040

41-
override def physicalDataType: PhysicalDataType = PhysicalCalendarIntervalType
41+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalCalendarIntervalType
4242

4343
override def typeName: String = "interval"
4444

sql/catalyst/src/main/scala/org/apache/spark/sql/types/CharType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ case class CharType(length: Int) extends AtomicType {
3333
private[sql] val ordering = implicitly[Ordering[InternalType]]
3434

3535
override def defaultSize: Int = length
36-
override def physicalDataType: PhysicalDataType = PhysicalStringType
36+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalStringType
3737
override def typeName: String = s"char($length)"
3838
override def toString: String = s"CharType($length)"
3939
private[spark] override def asNullable: CharType = this

sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ abstract class DataType extends AbstractDataType {
119119

120120
override private[sql] def acceptsType(other: DataType): Boolean = sameType(other)
121121

122-
def physicalDataType: PhysicalDataType = UninitializedPhysicalType
122+
private[sql] def physicalDataType: PhysicalDataType = UninitializedPhysicalType
123123
}
124124

125125

sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class DateType private() extends DatetimeType {
4747
*/
4848
override def defaultSize: Int = 4
4949

50-
override def physicalDataType: PhysicalDataType = PhysicalIntegerType
50+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalIntegerType
5151

5252
private[spark] override def asNullable: DateType = this
5353
}

sql/catalyst/src/main/scala/org/apache/spark/sql/types/DayTimeIntervalType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ case class DayTimeIntervalType(startField: Byte, endField: Byte) extends AnsiInt
6161
*/
6262
override def defaultSize: Int = 8
6363

64-
override def physicalDataType: PhysicalDataType = PhysicalLongType
64+
private[sql] override def physicalDataType: PhysicalDataType = PhysicalLongType
6565

6666
private[spark] override def asNullable: DayTimeIntervalType = this
6767

sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ case class DecimalType(precision: Int, scale: Int) extends FractionalType {
111111
*/
112112
override def defaultSize: Int = if (precision <= Decimal.MAX_LONG_DIGITS) 8 else 16
113113

114-
override def physicalDataType: PhysicalDataType = PhysicalDecimalType(precision, scale)
114+
private[sql] override def physicalDataType: PhysicalDataType =
115+
PhysicalDecimalType(precision, scale)
115116

116117
override def simpleString: String = s"decimal($precision,$scale)"
117118

0 commit comments

Comments
 (0)