Revert to aborting precondition for function inputs

Author: thk123

src/util/string_utils.cpp

@@ -53,11 +53,8 @@ void split_string(
   bool remove_empty)
 {
   PRECONDITION(result.empty());
-  if(strip && std::isspace(delim))
-  {
-    throw std::invalid_argument(
-      "delim can't be a space character if using strip");
-  }
+  // delim can't be a space character if using strip
+  PRECONDITION(!std::isspace(delim) || !strip);
 
   if(s.empty())
   {
@@ -106,11 +103,8 @@ void split_string(
   std::string &right,
   bool strip)
 {
-  if(strip && std::isspace(delim))
-  {
-    throw std::invalid_argument(
-      "delim can't be a space character if using strip");
-  }
+  // delim can't be a space character if using strip
+  PRECONDITION(!std::isspace(delim) || !strip);
 
   std::vector<std::string> result;
 

unit/util/string_utils/split_string.cpp

@@ -165,26 +165,8 @@ SCENARIO("split_string", "[core][utils][string_utils][split_string]")
           Catch::Matchers::Vector::EqualsMatcher<std::string>{expected_result});
       }
     }
-    WHEN("Stripping, not removing empty")
-    {
-      std::vector<std::string> result;
-      THEN("Should throw an exception")
-      {
-        REQUIRE_THROWS_AS(
-          split_string(string, delimiter, result, true, false),
-          std::invalid_argument);
-      }
-    }
-    WHEN("Stripping and removing empty")
-    {
-      std::vector<std::string> result;
-      THEN("Should throw an exception")
-      {
-        REQUIRE_THROWS_AS(
-          split_string(string, delimiter, result, true, true),
-          std::invalid_argument);
-      }
-    }
+    // TODO(tkiley): here we should check what happens when trying to enable
+    // TODO(tkiley): strip, but currently the behaviour terminates the unit test
   }
 }
 
@@ -223,15 +205,7 @@ SCENARIO("split_string into two", "[core][utils][string_utils][split_string]")
         REQUIRE(s2 == "b");
       }
     }
-    WHEN("Splitting in two and stripping")
-    {
-      THEN("An invalid argument exception should be raised")
-      {
-        std::string s1;
-        std::string s2;
-        REQUIRE_THROWS_AS(
-          split_string(string, delimiter, s1, s2, true), std::invalid_argument);
-      }
-    }
+    // TODO(tkiley): here we should check what happens when trying to enable
+    // TODO(tkiley): strip, but currently the behaviour terminates the unit test
   }
 }