Adding a warning and a commentary for unsupported generics, cleaning

Author: svorenova

src/java_bytecode/java_bytecode_convert_class.cpp

@@ -117,9 +117,8 @@ void java_bytecode_convert_classt::convert(const classt &c)
     }
     catch(unsupported_java_class_siganture_exceptiont)
     {
-      // Do nothing: we don't support parsing for example double bounded or
-      // two entry elements
-
+      warning() << "we currently don't support parsing for example double "
+        "bounded, recursive and wild card generics" << eom;
     }
   }
 

src/java_bytecode/java_types.cpp

@@ -201,6 +201,13 @@ typet java_type_from_string(
       // type parameters (e.g. on generic methods on non-generic classes
       // or generic static methods). For now we skip over this part of the
       // signature and continue parsing the rest of the signature as normal
+      // So for example, the following java method:
+      // static void <T, U> foo(T t, U u, int x);
+      // Would have a signature that looks like:
+      // <T:Ljava/lang/Object;U:Ljava/lang/Object;>(TT;TU;I)V
+      // So we skip all inside the angle brackets and parse the rest of the
+      // string:
+      // (TT;TU;I)V
       size_t closing_generic=find_closing_delimiter(src, 0, '<', '>');
       const typet &method_type=java_type_from_string(
         src.substr(closing_generic+1, std::string::npos), class_name);

src/java_bytecode/java_types.h

@@ -15,6 +15,7 @@ Author: Daniel Kroening, [email protected]
 #include <util/std_types.h>
 #include <util/c_types.h>
 #include <util/config.h>
+#include <util/optional.h>
 
 class java_class_typet:public class_typet
 {
@@ -366,7 +367,8 @@ class unsupported_java_class_siganture_exceptiont:public std::logic_error
 inline typet java_type_from_string_with_exception(
   const std::string &descriptor,
   const optionalt<std::string> &signature,
-  const std::string &class_name) {
+  const std::string &class_name)
+{
   try
   {
     return java_type_from_string(signature.value(), class_name);