Skip to content

Commit 67066a4

Browse files
committed
Revert compatibility_test.go to reflect.DeepEqual
This test doesn't go through the consolidator, so neither side will have proto3Rows set. Keep reflect.DeepEqual to preserve StatusFlags coverage. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> but with every line reviewed by me :) Signed-off-by: Brett Wines <bwines@slack-corp.com>
1 parent 39ac3f5 commit 67066a4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

go/vt/vttablet/endtoend/compatibility_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package endtoend
1818

1919
import (
20+
"reflect"
2021
"strings"
2122
"testing"
2223

@@ -693,7 +694,7 @@ func TestJSONType(t *testing.T) {
693694
},
694695
StatusFlags: sqltypes.ServerStatusNoIndexUsed | sqltypes.ServerStatusAutocommit,
695696
}
696-
if !want.Equal(qr) {
697+
if !reflect.DeepEqual(qr, want) {
697698
// MariaDB 10.3 has different behavior.
698699
want2 := want.Copy()
699700
want2.Fields[1].Type = sqltypes.Blob

0 commit comments

Comments
 (0)