Skip to content

[Patch] Added call block#897

Closed
KarimNahas wants to merge 1 commit into
slack-go:masterfrom
QuanteriumTech:feat/call-block
Closed

[Patch] Added call block#897
KarimNahas wants to merge 1 commit into
slack-go:masterfrom
QuanteriumTech:feat/call-block

Conversation

@KarimNahas

Copy link
Copy Markdown
Contributor

PR Content:

  • Added call block to the list of accepted blocks.

Note: this is needed to be able to parse Zoom bot messages.

@KarimNahas

Copy link
Copy Markdown
Contributor Author

@kanata2 Not too sure if I should add any additional tests for this, as call blocks are not really well documented.
Thanks!

@kanata2 kanata2 modified the milestone: v0.9.0 Apr 18, 2021
@petehamilton

petehamilton commented Sep 1, 2021

Copy link
Copy Markdown

We've done something very similar in our fork 😄 - @kanata2 anything we can do to help get this merged?

@kanata2

kanata2 commented Sep 6, 2021

Copy link
Copy Markdown
Member

Sorry for my slow response. I'll confirm later.

@petehamilton Thanks for your help 🙏

@sophiekoonin

Copy link
Copy Markdown

@kanata2 Hey! Would it be possible to get this merged in? We really need it for our project.

@kanata2

kanata2 commented Oct 31, 2021

Copy link
Copy Markdown
Member

@sophiekoonin I'll confirm later. Sorry for bothering you.

@sophiekoonin

Copy link
Copy Markdown

@kanata2 Thank you so much ❤️

@zchee zchee self-requested a review February 26, 2022 10:59
@zchee zchee added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Feb 26, 2022
@zchee

zchee commented Feb 26, 2022

Copy link
Copy Markdown
Contributor

@KarimNahas Hi, this is newer slack-go maintainer.

I can review it ASAP. So sorry, could you rebase it?

cc: @petehamilton @sophiekoonin

@github-actions

github-actions Bot commented Apr 5, 2023

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale label Apr 5, 2023
@kanata2 kanata2 removed the stale label Apr 5, 2023
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale label May 22, 2023
@kanata2 kanata2 added needs review and removed stale feedback given When a review has been conducted and awaiting the response from the comitter(s) labels May 22, 2023
@nlopes nlopes self-assigned this Jun 8, 2025
@nlopes nlopes closed this in c641d27 Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants