Skip to content

Commit 6607655

Browse files
kenzieschmollcommit-bot@chromium.org
authored andcommitted
[vm_snapshot_analysis] move command/* lib files out of bin
The files in `command/*` were moved as part of https://dart-review.googlesource.com/c/sdk/+/154360. This CL responds to Slava's comment "FWIW having this files in bin violates pub layout guidelines and looks pretty different from all other packages we have: bin/ is a folder for scripts. Libraries should live in lib." I verified in DevTools that with this change, we can still import files from package:vm_snapshot_analysis and run on the web (as long as we do not import files that depend on dart:io - lib/commands/utils.dart) Change-Id: I8c4f2a55c9cf346260fa5b80116c21993ccfc249 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154481 Reviewed-by: Vyacheslav Egorov <[email protected]> Commit-Queue: Kenzie Schmoll <[email protected]>
1 parent 8a4f583 commit 6607655

File tree

8 files changed

+9
-6
lines changed

8 files changed

+9
-6
lines changed

pkg/vm_snapshot_analysis/CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
# Changelog
22

3+
## 0.5.1-dev.1
4+
- Move `commands` back to lib.
5+
36
## 0.5.0+1
47
- Fix broken package by moving non-executable file out of bin/ directory.
58

69
## 0.5.0
7-
- Remove `dart:io` dependency from package `lib`, and move commands to `bin`.
10+
- Remove `dart:io` dependency from package `lib`, and move `commands` to `bin`.
811
- Replace `loadProgramInfo` util method with `loadProgramInfoFromJson`, which
912
expects an `Object` parameter instead of a `File` parameter.
1013
- `buildComparisonTreemap` now expects two `Object` parameters for `oldJson` and

pkg/vm_snapshot_analysis/bin/analyse.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import 'dart:io';
77

88
import 'package:args/command_runner.dart';
99

10-
import 'commands/compare.dart';
11-
import 'commands/explain.dart';
12-
import 'commands/summary.dart';
13-
import 'commands/treemap.dart';
10+
import 'package:vm_snapshot_analysis/src/commands/compare.dart';
11+
import 'package:vm_snapshot_analysis/src/commands/explain.dart';
12+
import 'package:vm_snapshot_analysis/src/commands/summary.dart';
13+
import 'package:vm_snapshot_analysis/src/commands/treemap.dart';
1414

1515
final _executableName = () {
1616
// There is no reliable way to detect executable name across different modes

pkg/vm_snapshot_analysis/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: vm_snapshot_analysis
22
description: Utilities for analysing AOT snapshot size.
3-
version: 0.5.0+1
3+
version: 0.5.1-dev.1
44

55
homepage: https://github.com/dart-lang/sdk/tree/master/pkg/vm_snapshot_analysis
66

0 commit comments

Comments
 (0)