Version 2.19.0-392.0.dev

Merge 6ddd146 into dev

Author: Dart CI

DEPS

@@ -66,7 +66,7 @@ vars = {
   # Checkout extra javascript engines for testing or benchmarking.
   # d8, the V8 shell, is always checked out.
   "checkout_javascript_engines": False,
-  "d8_tag": "version:10.7.157",
+  "d8_tag": "version:10.9.104",
   "jsshell_tag": "version:95.0",
 
   # As Flutter does, we use Fuchsia's GN and Clang toolchain. These revision

pkg/analyzer/lib/dart/constant/value.dart

@@ -136,7 +136,6 @@ abstract class DartObject {
   /// or `null` if
   /// * this object is not of type 'Symbol', or
   /// * the value of the object being represented is `null`.
-  /// (We return the string
   String? toSymbolValue();
 
   /// Return the representation of the type corresponding to the value of the

pkg/dart2wasm/bin/run_wasm.js

@@ -6,7 +6,7 @@
 //
 // Run as follows:
 //
-// $> d8 --experimental-wasm-gc --wasm-gc-js-interop --experimental-wasm-stack-switching --experimental-wasm-type-reflection run_wasm.js -- <dart_module>.wasm [<ffi_module>.wasm]
+// $> d8 --experimental-wasm-gc --experimental-wasm-stack-switching --experimental-wasm-type-reflection run_wasm.js -- <dart_module>.wasm [<ffi_module>.wasm]
 //
 // If an FFI module is specified, it will be instantiated first, and its
 // exports will be supplied as imports to the Dart module under the 'ffi'

pkg/dart2wasm/dart2wasm.md

@@ -25,7 +25,7 @@ where *options* include:
 
 The resulting `.wasm` file can be run with:
 
-`d8 --experimental-wasm-gc --wasm-gc-js-interop --experimental-wasm-stack-switching --experimental-wasm-type-reflection pkg/dart2wasm/bin/run_wasm.js -- `*outfile*`.wasm`
+`d8 --experimental-wasm-gc --experimental-wasm-stack-switching --experimental-wasm-type-reflection pkg/dart2wasm/bin/run_wasm.js -- `*outfile*`.wasm`
 
 ## Imports and exports
 

pkg/front_end/lib/src/fasta/builder/record_type_builder.dart

@@ -154,6 +154,12 @@ abstract class RecordTypeBuilder extends TypeBuilder {
             hasErrors = true;
             continue;
           }
+          if (forbiddenObjectMemberNames.contains(fieldName)) {
+            library.addProblem(messageObjectMemberNameUsedForRecordField,
+                field.charOffset, fieldName.length, fileUri);
+            hasErrors = true;
+            continue;
+          }
           RecordTypeFieldBuilder? existingField = fieldsMap[fieldName];
           if (existingField != null) {
             library.addProblem(

pkg/front_end/testcases/records/restricted_object_member_names.dart

@@ -2,15 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// 'Object' member names are allowed as the names of the positional fields in
-// record types because they don't introduce getters with those names.
-(int hashCode,) foo1() => throw 0; // Ok.
-(int runtimeType,) foo2() => throw 0; // Ok.
-(int noSuchMethod,) foo3() => throw 0; // Ok.
-(int toString,) foo4() => throw 0; // Ok.
-
-// 'Object' member names are forbidden as names of the named record fields in
-// both record types and literals.
+(int hashCode,) foo1() => throw 0; // Error.
+(int runtimeType,) foo2() => throw 0; // Error.
+(int noSuchMethod,) foo3() => throw 0; // Error.
+(int toString,) foo4() => throw 0; // Error.
 ({int hashCode}) foo5() => throw 0; // Error.
 ({int runtimeType}) foo6() => throw 0; // Error.
 ({int noSuchMethod}) foo7() => throw 0; // Error.

pkg/front_end/testcases/records/restricted_object_member_names.dart.strong.expect

@@ -2,48 +2,64 @@ library /*isNonNullableByDefault*/;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:5:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int hashCode,) foo1() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:6:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int runtimeType,) foo2() => throw 0; // Error.
+//      ^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:7:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int noSuchMethod,) foo3() => throw 0; // Error.
+//      ^^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:8:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int toString,) foo4() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:9:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int hashCode}) foo5() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:10:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int runtimeType}) foo6() => throw 0; // Error.
 //       ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:11:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int noSuchMethod}) foo7() => throw 0; // Error.
 //       ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:17:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:12:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int toString}) foo8() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:18:12: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:13:12: Error: Record field names can't be the same as a member from 'Object'.
 // foo9() => (hashCode: 1); // Error.
 //            ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:19:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo10() => (runtimeType: 1); // Error.
 //             ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:20:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo11() => (noSuchMethod: 1); // Error.
 //             ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:21:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo12() => (toString: 1); // Error.
 //             ^^^^^^^^
 //
 import self as self;
 import "dart:core" as core;
 
-static method foo1() → (core::int)
+static method foo1() → invalid-type
   return throw 0;
-static method foo2() → (core::int)
+static method foo2() → invalid-type
   return throw 0;
-static method foo3() → (core::int)
+static method foo3() → invalid-type
   return throw 0;
-static method foo4() → (core::int)
+static method foo4() → invalid-type
   return throw 0;
 static method foo5() → invalid-type
   return throw 0;

pkg/front_end/testcases/records/restricted_object_member_names.dart.strong.transformed.expect

@@ -2,48 +2,64 @@ library /*isNonNullableByDefault*/;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:5:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int hashCode,) foo1() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:6:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int runtimeType,) foo2() => throw 0; // Error.
+//      ^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:7:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int noSuchMethod,) foo3() => throw 0; // Error.
+//      ^^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:8:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int toString,) foo4() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:9:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int hashCode}) foo5() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:10:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int runtimeType}) foo6() => throw 0; // Error.
 //       ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:11:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int noSuchMethod}) foo7() => throw 0; // Error.
 //       ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:17:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:12:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int toString}) foo8() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:18:12: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:13:12: Error: Record field names can't be the same as a member from 'Object'.
 // foo9() => (hashCode: 1); // Error.
 //            ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:19:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo10() => (runtimeType: 1); // Error.
 //             ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:20:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo11() => (noSuchMethod: 1); // Error.
 //             ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:21:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo12() => (toString: 1); // Error.
 //             ^^^^^^^^
 //
 import self as self;
 import "dart:core" as core;
 
-static method foo1() → (core::int)
+static method foo1() → invalid-type
   return throw 0;
-static method foo2() → (core::int)
+static method foo2() → invalid-type
   return throw 0;
-static method foo3() → (core::int)
+static method foo3() → invalid-type
   return throw 0;
-static method foo4() → (core::int)
+static method foo4() → invalid-type
   return throw 0;
 static method foo5() → invalid-type
   return throw 0;
@@ -65,8 +81,8 @@ static method main() → dynamic {}
 
 
 Extra constant evaluation status:
-Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:18:11 -> RecordConstant(const ({hashCode: 1}))
-Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:19:12 -> RecordConstant(const ({runtimeType: 1}))
-Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:20:12 -> RecordConstant(const ({noSuchMethod: 1}))
-Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:21:12 -> RecordConstant(const ({toString: 1}))
+Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:13:11 -> RecordConstant(const ({hashCode: 1}))
+Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:14:12 -> RecordConstant(const ({runtimeType: 1}))
+Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:15:12 -> RecordConstant(const ({noSuchMethod: 1}))
+Evaluated: RecordLiteral @ org-dartlang-testcase:///restricted_object_member_names.dart:16:12 -> RecordConstant(const ({toString: 1}))
 Extra constant evaluation: evaluated: 12, effectively constant: 4

pkg/front_end/testcases/records/restricted_object_member_names.dart.weak.expect

@@ -2,48 +2,64 @@ library /*isNonNullableByDefault*/;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:5:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int hashCode,) foo1() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:6:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int runtimeType,) foo2() => throw 0; // Error.
+//      ^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:7:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int noSuchMethod,) foo3() => throw 0; // Error.
+//      ^^^^^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:8:6: Error: Record field names can't be the same as a member from 'Object'.
+// (int toString,) foo4() => throw 0; // Error.
+//      ^^^^^^^^
+//
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:9:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int hashCode}) foo5() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:10:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int runtimeType}) foo6() => throw 0; // Error.
 //       ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:11:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int noSuchMethod}) foo7() => throw 0; // Error.
 //       ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:17:7: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:12:7: Error: Record field names can't be the same as a member from 'Object'.
 // ({int toString}) foo8() => throw 0; // Error.
 //       ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:18:12: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:13:12: Error: Record field names can't be the same as a member from 'Object'.
 // foo9() => (hashCode: 1); // Error.
 //            ^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:19:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:14:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo10() => (runtimeType: 1); // Error.
 //             ^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:20:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:15:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo11() => (noSuchMethod: 1); // Error.
 //             ^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/records/restricted_object_member_names.dart:21:13: Error: Record field names can't be the same as a member from 'Object'.
+// pkg/front_end/testcases/records/restricted_object_member_names.dart:16:13: Error: Record field names can't be the same as a member from 'Object'.
 // foo12() => (toString: 1); // Error.
 //             ^^^^^^^^
 //
 import self as self;
 import "dart:core" as core;
 
-static method foo1() → (core::int)
+static method foo1() → invalid-type
   return throw 0;
-static method foo2() → (core::int)
+static method foo2() → invalid-type
   return throw 0;
-static method foo3() → (core::int)
+static method foo3() → invalid-type
   return throw 0;
-static method foo4() → (core::int)
+static method foo4() → invalid-type
   return throw 0;
 static method foo5() → invalid-type
   return throw 0;