Use stable, revert changes in ForbidNotNormalizedTypeRule

Author: janedbal

composer.json

@@ -25,7 +25,6 @@
         "shipmonk/name-collision-detector": "^2.0.0",
         "slevomat/coding-standard": "^8.0.1"
     },
-    "minimum-stability": "dev",
     "autoload": {
         "psr-4": {
             "ShipMonk\\PHPStan\\": "src/"

composer.lock

@@ -100,14 +100,17 @@ public function processNode(
         }
 
         if ($node instanceof Property) {
-            return $this->checkPropertyNativeType($node, $scope);
+            return array_merge(
+                $this->checkPropertyPhpDoc($node, $scope),
+                $this->checkPropertyNativeType($node, $scope),
+            );
         }
 
         if ($node instanceof Catch_) {
             return $this->checkCatchNativeType($node, $scope);
         }
 
-        return $this->checkVarDoc($node, $scope);
+        return $this->checkInlineVarDoc($node, $scope);
     }
 
     /**
@@ -205,11 +208,38 @@ private function checkParamAndReturnNativeType(FunctionLike $node, Scope $scope)
     }
 
     /**
-     * Checks inline var docs and property var docs
-     *
      * @return list<IdentifierRuleError>
      */
-    private function checkVarDoc(PhpParserNode $node, Scope $scope): array
+    private function checkPropertyPhpDoc(
+        Property $node,
+        Scope $scope
+    ): array
+    {
+        $errors = [];
+
+        $resolvedPhpDoc = $this->resolvePhpDoc($node, $scope);
+
+        if ($resolvedPhpDoc === null) {
+            return [];
+        }
+
+        $nameScope = $resolvedPhpDoc->getNullableNameScope();
+
+        if ($nameScope === null) {
+            return [];
+        }
+
+        foreach ($resolvedPhpDoc->getPhpDocNodes() as $phpdocNode) {
+            $errors = array_merge($errors, $this->processVarTags($node, $phpdocNode->getVarTagValues(), $nameScope));
+        }
+
+        return $errors;
+    }
+
+    /**
+     * @return list<IdentifierRuleError>
+     */
+    private function checkInlineVarDoc(PhpParserNode $node, Scope $scope): array
     {
         $docComment = $node->getDocComment();
 

src/Rule/ForbidNotNormalizedTypeRule.php

@@ -156,7 +156,7 @@ private function processExceptionCreation(
     }
 
     /**
-     * @return ParameterReflection[]
+     * @return list<ParameterReflection>
      */
     private function getCallLikeParameters(CallLike $node, Scope $scope): array
     {