Avoid synchronous event when creating Connection

Author: gkubisa

lib/client/connection.js

@@ -5,6 +5,11 @@ var ShareDBError = require('../error');
 var types = require('../types');
 var util = require('../util');
 
+function connectionState(socket) {
+  if (socket.readyState === 0 || socket.readyState === 1) return 'connecting';
+  return 'disconnected';
+}
+
 /**
  * Handles communication with the sharejs server and provides queries and
  * documents.
@@ -48,7 +53,7 @@ function Connection(socket) {
 
   this.debug = false;
 
-  this.state = 'disconnected'
+  this.state = connectionState(socket);
 
   this.bindToSocket(socket);
 }
@@ -92,7 +97,8 @@ Connection.prototype.bindToSocket = function(socket) {
   // - 'disconnected' Connection is closed, but it will reconnect automatically
   // - 'closed'       The connection was closed by the client, and will not reconnect
   // - 'stopped'      The connection was closed by the server, and will not reconnect
-  this._setState((socket.readyState === 0 || socket.readyState === 1) ? 'connecting' : 'disconnected');
+  var newState = connectionState(socket);
+  this._setState(newState);
 
   // This is a helper variable the document uses to see whether we're
   // currently in a 'live' state. It is true if and only if we're connected