add support for deletesnaps & CRDs required for volume snapshot

Author: Pearl1594

README.md

@@ -1,3 +1,7 @@
+**Fork Notice:** 
+
+This repo is a fork of the Leaseweb's maitained cloudstack-csi-driver, which is in-turn a fork of Apalia's cloudstack-csi-driver
+
 # CloudStack CSI Driver
 
 [![Go Reference](https://pkg.go.dev/badge/github.com/shapeblue/cloudstack-csi-driver.svg)](https://pkg.go.dev/github.com/shapeblue/cloudstack-csi-driver)
@@ -83,6 +87,17 @@ disk offerings to Kubernetes storage classes.
 
 [More info...](./cmd/cloudstack-csi-sc-syncer/README.md)
 
+> **Note:** The VolumeSnapshot CRDs (CustomResourceDefinitions) of version 8.3.0 are installed in this deployment. If you use a different version, please ensure compatibility with your Kubernetes cluster and CSI sidecars.
+
+// TODO: Ask Wei / Rohit - should we have the crds locally or manually install it from:
+
+```
+kubectl apply -f https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v8.3.0/client/config/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml
+kubectl apply -f https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v8.3.0/client/config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml
+kubectl apply -f https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v8.3.0/client/config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml
+
+```
+
 ### Usage
 
 Example:

deploy/snapshot-cdrs.yaml

@@ -8,4 +8,4 @@ spec:
   resources:
     requests:
       storage: 10Gi
-  storageClassName: cloudstack-custom
+  storageClassName: cloudstack-custom

examples/k8s/snapshot/pvc.yaml

@@ -5,4 +5,4 @@ metadata:
 spec:
   volumeSnapshotClassName: cloudstack-snapshot
   source:
-    persistentVolumeClaimName: my-pvc
+    persistentVolumeClaimName: my-pvc

examples/k8s/snapshot/snapshot.yaml

@@ -25,6 +25,7 @@ type Interface interface {
 	ExpandVolume(ctx context.Context, volumeID string, newSizeInGB int64) error
 
 	CreateVolumeFromSnapshot(ctx context.Context, diskOfferingID, zoneID, name, domainID, projectID, snapshotID string, sizeInGB int64) (string, error)
+	GetSnapshotByID(ctx context.Context, snapshotID ...string) (*Snapshot, error)
 	CreateSnapshot(ctx context.Context, volumeID string) (*Snapshot, error)
 	DeleteSnapshot(ctx context.Context, snapshotID string) error
 }

pkg/cloud/cloud.go

@@ -12,6 +12,7 @@ import (
 )
 
 const zoneID = "a1887604-237c-4212-a9cd-94620b7880fa"
+const snapshotID = "9d076136-657b-4c84-b279-455da3ea484c"
 
 type fakeConnector struct {
 	node          *cloud.VM
@@ -41,7 +42,7 @@ func New() cloud.Interface {
 		ID:        "9d076136-657b-4c84-b279-455da3ea484c",
 		Name:      "pvc-vol-snap-1",
 		DomainID:  "51f0fcb5-db16-4637-94f5-30131010214f",
-		ZoneID:    "bdab539f-651e-431a-979d-5d3c48b54fcf",
+		ZoneID:    zoneID,
 		VolumeID:  "4f1f610d-6f17-4ff9-9228-e4062af93e54",
 		CreatedAt: "2025-07-07 16:13:06",
 	}
@@ -140,6 +141,10 @@ func (f *fakeConnector) CreateVolumeFromSnapshot(ctx context.Context, diskOfferi
 	return "1", nil
 }
 
+func (f *fakeConnector) GetSnapshotByID(ctx context.Context, snapshotID ...string) (*cloud.Snapshot, error) {
+	return f.snapshot, nil
+}
+
 func (f *fakeConnector) CreateSnapshot(ctx context.Context, volumeID string) (*cloud.Snapshot, error) {
 	return f.snapshot, nil
 }

pkg/cloud/fake/fake.go

@@ -4,12 +4,15 @@ import (
 	"context"
 	"strings"
 
-	"github.com/apache/cloudstack-go/v2/cloudstack"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 )
 
-func (c *client) ListSnapshots(p *cloudstack.ListSnapshotsParams) (*Snapshot, error) {
+func (c *client) GetSnapshotByID(ctx context.Context, snapshotID ...string) (*Snapshot, error) {
+	p := c.Snapshot.NewListSnapshotsParams()
+	if snapshotID != nil {
+		p.SetId(snapshotID[0])
+	}
 	l, err := c.Snapshot.ListSnapshots(p)
 	if err != nil {
 		return nil, err

pkg/cloud/snapshots.go

@@ -295,7 +295,6 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
 	return &csi.DeleteVolumeResponse{}, nil
 }
 
-// CreateSnapshot call blockstorage SnapshotVolume.
 func (cs *controllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateSnapshotRequest) (*csi.CreateSnapshotResponse, error) {
 	klog.V(4).Infof("CreateSnapshot")
 
@@ -312,7 +311,7 @@ func (cs *controllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateS
 		return nil, status.Errorf(codes.Internal, "Failed to create snapshot %s: %v", snapshot.ID, err.Error())
 	}
 
-	t, err := time.Parse(time.RFC3339, snapshot.CreatedAt)
+	t, err := time.Parse("2006-01-02T15:04:05-0700", snapshot.CreatedAt)
 	if err != nil {
 		panic(err)
 	}
@@ -333,6 +332,31 @@ func (cs *controllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateS
 
 }
 
+func (cs *controllerServer) DeleteSnapshot(ctx context.Context, req *csi.DeleteSnapshotRequest) (*csi.DeleteSnapshotResponse, error) {
+	klog.V(4).Infof("DeleteSnapshot")
+
+	snapshotID := req.GetSnapshotId()
+
+	if snapshotID == "" {
+		return nil, status.Error(codes.InvalidArgument, "Snapshot ID missing in request")
+	}
+
+	snapshot, err := cs.connector.GetSnapshotByID(ctx, snapshotID)
+	if errors.Is(err, cloud.ErrNotFound) {
+		return nil, status.Errorf(codes.NotFound, "Snapshot %v not found", snapshotID)
+	} else if err != nil {
+		// Error with CloudStack
+		return nil, status.Errorf(codes.Internal, "Error %v", err)
+	}
+
+	err = cs.connector.DeleteSnapshot(ctx, snapshot.ID)
+	if err != nil && !errors.Is(err, cloud.ErrNotFound) {
+		return nil, status.Errorf(codes.Internal, "Cannot delete snapshot %s: %s", snapshotID, err.Error())
+	}
+
+	return &csi.DeleteSnapshotResponse{}, nil
+}
+
 func (cs *controllerServer) ControllerPublishVolume(ctx context.Context, req *csi.ControllerPublishVolumeRequest) (*csi.ControllerPublishVolumeResponse, error) {
 	logger := klog.FromContext(ctx)
 	logger.V(6).Info("ControllerPublishVolume: called", "args", *req)