(breaking change) Don't implement Floor, Ceil and Round on integer types. #449
Conversation
I can't see a reason to have it.
nical
changed the title
|
@bors-servo r+ |
|
📌 Commit 609955f has been approved by |
|
☀️ Test successful - checks-travis |
|
I actually have a use case for exactly this and discovered this issue when fixing my build after upgrading to euclid 0.22. Having these implementations allows me to treat f32, i32 the same in a generic context where getting the i32 bounding box is important. It's not critical for me because I can work around the problem basically by making my own trait for it with a round_out method that is a no-op for integers, but it's slightly annoying. If it would be welcome, I'd make a PR to add this back, but I understand if it's just not an API surface you want in the future. |
|
I'm fine with adding it back. |
|
I ended up needing it twice, so I figure that passes the bar of being useful for me at least, so I made a PR: #464 |
I can't see a reason to have it.