Skip to content

Commit c9fe492

Browse files
committed
[rb] remove deprecated setter and getter methods for driver path in browser modules
1 parent 2a98236 commit c9fe492

File tree

8 files changed

+0
-120
lines changed

8 files changed

+0
-120
lines changed

rb/lib/selenium/webdriver/chrome.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ module Chrome
2828
autoload :Options, 'selenium/webdriver/chrome/options'
2929
autoload :Service, 'selenium/webdriver/chrome/service'
3030

31-
def self.driver_path=(path)
32-
WebDriver.logger.deprecate 'Selenium::WebDriver::Chrome#driver_path=',
33-
'Selenium::WebDriver::Chrome::Service#driver_path=',
34-
id: :driver_path
35-
Selenium::WebDriver::Chrome::Service.driver_path = path
36-
end
37-
38-
def self.driver_path
39-
WebDriver.logger.deprecate 'Selenium::WebDriver::Chrome#driver_path',
40-
'Selenium::WebDriver::Chrome::Service#driver_path',
41-
id: :driver_path
42-
Selenium::WebDriver::Chrome::Service.driver_path
43-
end
44-
4531
def self.path=(path)
4632
Platform.assert_executable path
4733
@path = path

rb/lib/selenium/webdriver/firefox.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,6 @@ module Firefox
4242
# until WebDriver Bidi is available.
4343
DEVTOOLS_VERSION = 85
4444

45-
def self.driver_path=(path)
46-
WebDriver.logger.deprecate 'Selenium::WebDriver::Firefox#driver_path=',
47-
'Selenium::WebDriver::Firefox::Service#driver_path=',
48-
id: :driver_path
49-
Selenium::WebDriver::Firefox::Service.driver_path = path
50-
end
51-
52-
def self.driver_path
53-
WebDriver.logger.deprecate 'Selenium::WebDriver::Firefox#driver_path',
54-
'Selenium::WebDriver::Firefox::Service#driver_path',
55-
id: :driver_path
56-
Selenium::WebDriver::Firefox::Service.driver_path
57-
end
58-
5945
def self.path=(path)
6046
Platform.assert_executable path
6147
@path = path

rb/lib/selenium/webdriver/ie.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,6 @@ module IE
2323
autoload :Driver, 'selenium/webdriver/ie/driver'
2424
autoload :Options, 'selenium/webdriver/ie/options'
2525
autoload :Service, 'selenium/webdriver/ie/service'
26-
27-
def self.driver_path=(path)
28-
WebDriver.logger.deprecate 'Selenium::WebDriver::IE#driver_path=',
29-
'Selenium::WebDriver::IE::Service#driver_path=',
30-
id: :driver_path
31-
Selenium::WebDriver::IE::Service.driver_path = path
32-
end
33-
34-
def self.driver_path
35-
WebDriver.logger.deprecate 'Selenium::WebDriver::IE#driver_path',
36-
'Selenium::WebDriver::IE::Service#driver_path',
37-
id: :driver_path
38-
Selenium::WebDriver::IE::Service.driver_path
39-
end
4026
end # IE
4127
end # WebDriver
4228
end # Selenium

rb/lib/selenium/webdriver/safari.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,6 @@ def path
5353

5454
raise Error::WebDriverError, 'Unable to find Safari'
5555
end
56-
57-
def driver_path=(path)
58-
WebDriver.logger.deprecate 'Selenium::WebDriver::Safari#driver_path=',
59-
'Selenium::WebDriver::Safari::Service#driver_path=',
60-
id: :driver_path
61-
Selenium::WebDriver::Safari::Service.driver_path = path
62-
end
63-
64-
def driver_path
65-
WebDriver.logger.deprecate 'Selenium::WebDriver::Safari#driver_path',
66-
'Selenium::WebDriver::Safari::Service#driver_path',
67-
id: :driver_path
68-
Selenium::WebDriver::Safari::Service.driver_path
69-
end
7056
end
7157
end # Safari
7258
end # WebDriver

rb/spec/unit/selenium/webdriver/chrome/service_spec.rb

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -70,22 +70,6 @@ module WebDriver
7070
expect(service.executable_path).to eq path
7171
end
7272

73-
it 'accepts Chrome#driver_path= and Chrome#driver_path but throws deprecation notices' do
74-
path = '/path/to/driver'
75-
76-
expect {
77-
Selenium::WebDriver::Chrome.driver_path = path
78-
}.to have_deprecated(:driver_path)
79-
80-
expect {
81-
expect(Selenium::WebDriver::Chrome.driver_path).to eq path
82-
}.to have_deprecated(:driver_path)
83-
84-
service = Service.chrome
85-
86-
expect(service.executable_path).to eq path
87-
end
88-
8973
it 'does not create args by default' do
9074
allow(Platform).to receive(:find_binary).and_return(service_path)
9175

rb/spec/unit/selenium/webdriver/firefox/service_spec.rb

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -68,22 +68,6 @@ module WebDriver
6868
expect(service.executable_path).to eq path
6969
end
7070

71-
it 'accepts Firefox#driver_path= but throws deprecation notice' do
72-
path = '/path/to/driver'
73-
74-
expect {
75-
Selenium::WebDriver::Firefox.driver_path = path
76-
}.to have_deprecated(:driver_path)
77-
78-
expect {
79-
expect(Selenium::WebDriver::Firefox.driver_path).to eq path
80-
}.to have_deprecated(:driver_path)
81-
82-
service = Service.firefox
83-
84-
expect(service.executable_path).to eq path
85-
end
86-
8771
it 'does not create args by default' do
8872
allow(Platform).to receive(:find_binary).and_return(service_path)
8973

rb/spec/unit/selenium/webdriver/ie/service_spec.rb

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -69,22 +69,6 @@ module WebDriver
6969
expect(service.executable_path).to eq path
7070
end
7171

72-
it 'accepts IE#driver_path= but throws deprecation notice' do
73-
path = '/path/to/driver'
74-
75-
expect {
76-
Selenium::WebDriver::IE.driver_path = path
77-
}.to have_deprecated(:driver_path)
78-
79-
expect {
80-
expect(Selenium::WebDriver::IE.driver_path).to eq path
81-
}.to have_deprecated(:driver_path)
82-
83-
service = Service.ie
84-
85-
expect(service.executable_path).to eq path
86-
end
87-
8872
it 'does not create args by default' do
8973
allow(Platform).to receive(:find_binary).and_return(service_path)
9074

rb/spec/unit/selenium/webdriver/safari/service_spec.rb

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -70,22 +70,6 @@ module WebDriver
7070
expect(service.executable_path).to eq path
7171
end
7272

73-
it 'accepts Safari#driver_path= but throws deprecation notice' do
74-
path = '/path/to/driver'
75-
76-
expect {
77-
Selenium::WebDriver::Safari.driver_path = path
78-
}.to have_deprecated(:driver_path)
79-
80-
expect {
81-
expect(Selenium::WebDriver::Safari.driver_path).to eq path
82-
}.to have_deprecated(:driver_path)
83-
84-
service = Service.safari
85-
86-
expect(service.executable_path).to eq path
87-
end
88-
8973
it 'does not create args by default' do
9074
allow(Platform).to receive(:find_binary).and_return(service_path)
9175

0 commit comments

Comments
 (0)