Skip to content

Commit 940fb53

Browse files
committed
Allow nullable values and check for request keys
1 parent 81420c2 commit 940fb53

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

database/migrations/create_elastic_email_hits_table.php.stub

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ class CreateElasticEmailHitsTable extends Migration
2424

2525
Schema::create('elastic_email_outbound', function (Blueprint $table) {
2626
$table->id();
27-
$table->string('message_id')->unique();
28-
$table->uuid('transaction_id')->unique();
27+
$table->string('message_id')->nullable()->unique();
28+
$table->uuid('transaction_id')->nullable()->unique();
2929
$table->string('from');
3030
$table->string('to');
3131
$table->string('cc')->nullable();

src/Listeners/OnEmailSent.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ public function handle(MessageSent $event)
1616
$body = $this->parseBodyText($event->message->getBody());
1717

1818
$log = ElasticEmailOutbound::create([
19-
'message_id' => $event->message->getHeaders()->get('X-Message-ID')->getFieldBody() ?? null,
20-
'transaction_id' => $event->message->getHeaders()->get('X-Transaction-ID')->getFieldBody() ?? null,
19+
'message_id' => !is_null($event->message->getHeaders()->get('X-Message-ID')) ? $event->message->getHeaders()->get('X-Message-ID')->getFieldBody() : null,
20+
'transaction_id' => !is_null($event->message->getHeaders()->get('X-Transaction-ID')) ? $event->message->getHeaders()->get('X-Transaction-ID')->getFieldBody() : null,
2121
'from' => $from[0],
2222
'to' => json_encode($toArr),
2323
'cc' => $ccArr ? json_encode($ccArr) : NULL,

src/Listeners/OnWebhookCall.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ class OnWebhookCall
1212
public function handle(WebhookCallReceived $event)
1313
{
1414
if (config('elasticemail.save_hits')) {
15+
16+
if(!isset($event->request->transaction) || !isset($event->request->messageid)){
17+
return false;
18+
}
19+
1520
ElasticEmailHit::create([
1621
'transaction_id' => $event->request->transaction,
1722
'message_id' => $event->request->messageid,

0 commit comments

Comments
 (0)