Skip to content

Commit 7f90e05

Browse files
lgritzscott-wilson
authored andcommitted
build: fix build_cmake.bash script for aarch64, bump its default version (AcademySoftwareFoundation#4581)
* When the script was run on aarch64, it was actually hard-coded to retrieve a version older than we currently require as a minimum. Use the CMAKE_VERSION hint just like we do for x86_64. * Bump the default version that this script makes to the latest, 3.31.3. (This does not change OIIO's minimum required cmake version, it merely changes the default if this hepler script that we use for CI is run without any specific version requested.) Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
1 parent 5b341cc commit 7f90e05

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

INSTALL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ NEW or CHANGED MINIMUM dependencies since the last major release are **bold**.
1919
CMake configuration flag: `-DCMAKE_CXX_STANDARD=20`, etc.
2020
* Compilers: **gcc 9.3** - 14.2, **clang 5** - 19, MSVS 2017 - 2019 (**v19.14
2121
and up**), **Intel icc 19+**, Intel OneAPI C++ compiler 2022+.
22-
* **CMake >= 3.18.2** (tested through 3.30)
22+
* **CMake >= 3.18.2** (tested through 3.31)
2323
* **Imath >= 3.1** (tested through 3.1.x and main)
2424
* **OpenEXR >= 3.1** (tested through 3.3 and main)
2525
* **libTIFF >= 4.0** (tested through 4.7)

src/build-scripts/build_cmake.bash

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ set -ex
1212
echo "Building cmake"
1313
uname
1414

15-
CMAKE_VERSION=${CMAKE_VERSION:=3.18.5}
15+
CMAKE_VERSION=${CMAKE_VERSION:=3.31.3}
1616
LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}
1717
CMAKE_INSTALL_DIR=${CMAKE_INSTALL_DIR:=${LOCAL_DEPS_DIR}/cmake}
1818

@@ -25,8 +25,8 @@ fi
2525

2626
if [[ `uname` == "Linux" && `uname -m` == "aarch64" ]] ; then
2727
mkdir -p ${CMAKE_INSTALL_DIR} || true
28-
curl --location https://anaconda.org/conda-forge/cmake/3.17.0/download/linux-aarch64/cmake-3.17.0-h28c56e5_0.tar.bz2 -o cmake-3.17.0-h28c56e5_0.tar.bz2
29-
tar -xjf cmake-3.17.0-h28c56e5_0.tar.bz2 -C ${CMAKE_INSTALL_DIR}
28+
curl --location "https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-Linux-aarch64.sh" -o "cmake.sh"
29+
sh cmake.sh --skip-license --prefix=${CMAKE_INSTALL_DIR}
3030
export PATH=${CMAKE_INSTALL_DIR}/bin:$PATH
3131

3232
# In case we ever need to build from scratch:

0 commit comments

Comments
 (0)