Skip to content

Commit 64b615d

Browse files
committed
Install ninja, which fixes the build error
1 parent 7b0c7ba commit 64b615d

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

tests/test_editable.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,29 @@ def test_cython_pxd(monkeypatch, tmp_path, editable):
5252
env.install("pip>=23")
5353
env.install("cython")
5454
env.install("scikit-build-core[pyproject]")
55+
env.install("ninja")
5556

56-
# This succeeds
5757
env.install(
58-
"-v", "--config-settings=build-dir=build/{wheel_tag}", *editable_flag, "."
58+
"-v",
59+
"--config-settings=build-dir=build/{wheel_tag}",
60+
"--no-build-isolation",
61+
*editable_flag,
62+
".",
63+
)
64+
65+
package2 = PackageInfo(
66+
"cython_pxd_editable/pkg2",
5967
)
68+
tmp_path2 = tmp_path / "pkg2"
69+
tmp_path2.mkdir()
70+
process_package(package2, tmp_path2, monkeypatch)
6071

61-
# This fails
6272
env.install(
6373
"-v",
6474
"--config-settings=build-dir=build/{wheel_tag}",
6575
"--no-build-isolation",
6676
*editable_flag,
6777
".",
6878
)
69-
70-
# package2 = PackageInfo(
71-
# "cython_pxd_editable/pkg2",
72-
# )
73-
# tmp_path2 = tmp_path / "pkg2"
74-
# tmp_path2.mkdir()
75-
# process_package(package2, tmp_path2, monkeypatch)
76-
#
77-
# env.install(
78-
# "-v", "--config-settings=build-dir=build/{wheel_tag}", "--no-build-isolation", *editable_flag, "."
79-
# )
8079
finally:
8180
shutil.rmtree(env_path, ignore_errors=True)

0 commit comments

Comments
 (0)