Skip to content

Commit fe90b8a

Browse files
authored
Merge 62ce5bb into 27f89d7
2 parents 27f89d7 + 62ce5bb commit fe90b8a

3 files changed

Lines changed: 24 additions & 60 deletions

File tree

.changeset/orange-streets-live.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ultraviolet/ui": patch
3+
---
4+
5+
`EmptyState`: small refactor to avoid empty divs

packages/ui/src/components/EmptyState/__tests__/__snapshots__/index.test.tsx.snap

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,6 @@ exports[`emptySpace > should work with border 1`] = `
2525
</p>
2626
</div>
2727
</div>
28-
<div
29-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
30-
>
31-
<div
32-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
33-
/>
34-
</div>
3528
content
3629
</div>
3730
</div>
@@ -71,13 +64,6 @@ exports[`emptySpace > should work with image 1`] = `
7164
</p>
7265
</div>
7366
</div>
74-
<div
75-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
76-
>
77-
<div
78-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
79-
/>
80-
</div>
8167
content
8268
</div>
8369
</div>
@@ -114,13 +100,6 @@ exports[`emptySpace > should work with image as component 1`] = `
114100
</p>
115101
</div>
116102
</div>
117-
<div
118-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
119-
>
120-
<div
121-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
122-
/>
123-
</div>
124103
content
125104
</div>
126105
</div>
@@ -156,9 +135,6 @@ exports[`emptySpace > should work with learn more 1`] = `
156135
<div
157136
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
158137
>
159-
<div
160-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
161-
/>
162138
<a
163139
class="styles__1dtqm9e0 styles_prominence_default__1dtqm9e3 styles_sentiment_info__1dtqm9e2 styles_oneLine_false__1dtqm9e8 styles_variant_bodyStrong__1dtqm9eb styles_type_standalone__1dtqm9ed styles_undefined_compound_4__1dtqm9ei styles__1dtqm9en"
164140
data-variant="standalone"
@@ -304,13 +280,6 @@ exports[`emptySpace > should work with size 1`] = `
304280
</p>
305281
</div>
306282
</div>
307-
<div
308-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
309-
>
310-
<div
311-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
312-
/>
313-
</div>
314283
content
315284
</div>
316285
</div>
@@ -349,13 +318,6 @@ exports[`emptySpace > should work with title 1`] = `
349318
</p>
350319
</div>
351320
</div>
352-
<div
353-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
354-
>
355-
<div
356-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
357-
/>
358-
</div>
359321
content
360322
</div>
361323
</div>
@@ -388,13 +350,6 @@ exports[`emptySpace > should work without parameters 1`] = `
388350
</p>
389351
</div>
390352
</div>
391-
<div
392-
class="styles__toi52u0 styles_alignItems_center_xxsmall__toi52ud styles_flexDirection_column_xxsmall__toi52u2d styles_gap_1rem_xxsmall__toi52u3v styles_justifyContent_center_xxsmall__toi52u61"
393-
>
394-
<div
395-
class="styles__toi52u0 styles_flexDirection_row_xxsmall__toi52u2j styles_gap_1rem_xxsmall__toi52u3v"
396-
/>
397-
</div>
398353
</div>
399354
</div>
400355
</div>

packages/ui/src/components/EmptyState/index.tsx

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,22 +108,26 @@ export const EmptyState = ({
108108
</Text>
109109
</Stack>
110110
</Stack>
111-
<Stack alignItems="center" gap={2} justifyContent="center">
112-
<Stack direction="row" gap={2}>
113-
{secondaryButton}
114-
{primaryButton}
111+
{primaryButton || secondaryButton || learnMore ? (
112+
<Stack alignItems="center" gap={2} justifyContent="center">
113+
{primaryButton || secondaryButton ? (
114+
<Stack direction="row" gap={2}>
115+
{secondaryButton}
116+
{primaryButton}
117+
</Stack>
118+
) : null}
119+
{learnMore?.text ? (
120+
<Link
121+
href={learnMore.link}
122+
iconPosition="right"
123+
size={size === 'small' ? 'small' : undefined}
124+
target={learnMore.target}
125+
>
126+
{learnMore.text}
127+
</Link>
128+
) : null}
115129
</Stack>
116-
{learnMore?.text ? (
117-
<Link
118-
href={learnMore.link}
119-
iconPosition="right"
120-
size={size === 'small' ? 'small' : undefined}
121-
target={learnMore.target}
122-
>
123-
{learnMore.text}
124-
</Link>
125-
) : null}
126-
</Stack>
130+
) : null}
127131
{children}
128132
</Stack>
129133
</Stack>

0 commit comments

Comments
 (0)