Skip to content

Commit f9f5baf

Browse files
fix(k8s): update field description (#3538)
Co-authored-by: Mia-Cross <lmarabese@scaleway.com>
1 parent 3068ee3 commit f9f5baf

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

cmd/scw/testdata/test-all-usage-k8s-node-delete-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ EXAMPLES:
1717

1818
ARGS:
1919
node-id ID of the node to replace
20-
[skip-drain] Skip draining node from its workload
20+
[skip-drain] Skip draining node from its workload (Note: this parameter is currently inactive)
2121
[replace] Add a new node after the deletion of this node
2222
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2323

docs/commands/k8s.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ scw k8s node delete <node-id ...> [arg=value ...]
672672
| Name | | Description |
673673
|------|---|-------------|
674674
| node-id | Required | ID of the node to replace |
675-
| skip-drain | | Skip draining node from its workload |
675+
| skip-drain | | Skip draining node from its workload (Note: this parameter is currently inactive) |
676676
| replace | | Add a new node after the deletion of this node |
677677
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
678678

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ require (
2424
github.com/moby/buildkit v0.11.6
2525
github.com/opencontainers/go-digest v1.0.0
2626
github.com/pkg/errors v0.9.1
27-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231213163330-12d10cd41f4b
27+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231214143654-2d31c8496902
2828
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
2929
github.com/spf13/cobra v1.8.0
3030
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
490490
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
491491
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
492492
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
493-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231213163330-12d10cd41f4b h1:oW4EdPDy3xTIvcxMqgnYSr8W8gUkIGz6y+ikPYpxML8=
494-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231213163330-12d10cd41f4b/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
493+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231214143654-2d31c8496902 h1:D0jF7Fw/hgyX/O+85mbAtaC4/E5tIGm+FiIhQycCCKw=
494+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231214143654-2d31c8496902/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
495495
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
496496
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
497497
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

internal/namespaces/k8s/v1/k8s_cli.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1989,7 +1989,7 @@ func k8sNodeDelete() *core.Command {
19891989
},
19901990
{
19911991
Name: "skip-drain",
1992-
Short: `Skip draining node from its workload`,
1992+
Short: `Skip draining node from its workload (Note: this parameter is currently inactive)`,
19931993
Required: false,
19941994
Deprecated: false,
19951995
Positional: false,

0 commit comments

Comments
 (0)