feat(rdb): cross AZ Read Replica (#3140)

Co-authored-by: Jules Castéran <[email protected]>

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-rdb-read-replica-create-usage.golden

@@ -9,6 +9,7 @@ ARGS:
   instance-id                                                  UUID of the Database Instance you want to create a Read Replica from
   [endpoint-spec.{index}.private-network.private-network-id]   UUID of the Private Network to be connected to the Read Replica
   [endpoint-spec.{index}.private-network.service-ip]           Endpoint IPv4 address with a CIDR notation. Refer to the official Scaleway documentation to learn more about IP and subnet limitations.
+  [same-zone]                                                  Defines whether to create the replica in the same availability zone as the main instance nodes or not.
   [region=fr-par]                                              Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
 
 FLAGS:

docs/commands/rdb.md

@@ -1192,6 +1192,7 @@ scw rdb read-replica create <instance-id ...> [arg=value ...]
 | instance-id | Required | UUID of the Database Instance you want to create a Read Replica from |
 | endpoint-spec.{index}.private-network.private-network-id |  | UUID of the Private Network to be connected to the Read Replica |
 | endpoint-spec.{index}.private-network.service-ip |  | Endpoint IPv4 address with a CIDR notation. Refer to the official Scaleway documentation to learn more about IP and subnet limitations. |
+| same-zone |  | Defines whether to create the replica in the same availability zone as the main instance nodes or not. |
 | region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
 
 

go.mod

@@ -26,7 +26,7 @@ require (
 	github.com/moby/buildkit v0.11.6
 	github.com/opencontainers/go-digest v1.0.0
 	github.com/pkg/errors v0.9.1
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.16.0.20230524124738-b9ba35117a52
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17
 	github.com/spf13/cobra v1.7.0
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.2

go.sum

@@ -483,8 +483,8 @@ github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncj
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.16.0.20230524124738-b9ba35117a52 h1:ib3iE5wJl//BpzUIuyZ3Fp2Caf8Zu5G6cA3sHHbuPx8=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.16.0.20230524124738-b9ba35117a52/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17 h1:1WuWJu7/e8SqK+uQl7lfk/N/oMZTL2NE/TJsNKRNMc4=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.17/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
 github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

internal/namespaces/rdb/v1/rdb_cli.go

@@ -1311,6 +1311,13 @@ func rdbReadReplicaCreate() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
+			{
+				Name:       "same-zone",
+				Short:      `Defines whether to create the replica in the same availability zone as the main instance nodes or not.`,
+				Required:   false,
+				Deprecated: false,
+				Positional: false,
+			},
 			core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
 		},
 		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {