feat(vpcgw): improve gateway-type list visualization (#2963)

Author: yfodil

internal/namespaces/vpcgw/v1/custom.go

@@ -12,5 +12,7 @@ func GetCommands() *core.Commands {
 	human.RegisterMarshalerFunc(vpcgw.GatewayNetworkStatus(""), human.EnumMarshalFunc(gatewayNetworkStatusMarshalSpecs))
 	human.RegisterMarshalerFunc(vpcgw.GatewayStatus(""), human.EnumMarshalFunc(gatewayStatusMarshalSpecs))
 
+	cmds.MustFind("vpc-gw", "gateway-type", "list").Override(vpcgwGatewayTypeListBuilder)
+
 	return cmds
 }

internal/namespaces/vpcgw/v1/custom_gateway_type.go

@@ -0,0 +1,22 @@
+package vpcgw
+
+import (
+	"context"
+
+	"github.com/scaleway/scaleway-cli/v2/internal/core"
+	"github.com/scaleway/scaleway-sdk-go/api/vpcgw/v1"
+)
+
+func vpcgwGatewayTypeListBuilder(c *core.Command) *core.Command {
+	c.AddInterceptors(func(ctx context.Context, argsI interface{}, runner core.CommandRunner) (interface{}, error) {
+		res, err := runner(ctx, argsI)
+		if err != nil {
+			return nil, err
+		}
+
+		typesResponse := res.(*vpcgw.ListGatewayTypesResponse)
+		return typesResponse.Types, nil
+	})
+
+	return c
+}

internal/namespaces/vpcgw/v1/custom_gateway_type_test.go

@@ -0,0 +1,15 @@
+package vpcgw
+
+import (
+	"testing"
+
+	"github.com/scaleway/scaleway-cli/v2/internal/core"
+)
+
+func Test_ListGatewayType(t *testing.T) {
+	t.Run("Simple", core.Test(&core.TestConfig{
+		Commands: GetCommands(),
+		Cmd:      "scw vpc-gw gateway-type list",
+		Check:    core.TestCheckGolden(),
+	}))
+}

internal/namespaces/vpcgw/v1/testdata/test-list-gateway-type-simple.cassette.yaml

@@ -0,0 +1,36 @@
+---
+version: 1
+interactions:
+- request:
+    body: ""
+    form: {}
+    headers:
+      User-Agent:
+      - scaleway-sdk-go/v1.0.0-beta.7+dev (go1.19.5; darwin; amd64) cli-e2e-test
+    url: https://api.scaleway.com/vpc-gw/v1/zones/fr-par-1/gateway-types
+    method: GET
+  response:
+    body: '{"types":[{"name":"VPC-GW-S", "bandwidth":100000000, "zone":"fr-par-1"},
+      {"name":"VPC-GW-M", "bandwidth":1000000000, "zone":"fr-par-1"}]}'
+    headers:
+      Content-Length:
+      - "137"
+      Content-Security-Policy:
+      - default-src 'none'; frame-ancestors 'none'
+      Content-Type:
+      - application/json
+      Date:
+      - Tue, 28 Mar 2023 13:19:36 GMT
+      Server:
+      - Scaleway API-Gateway
+      Strict-Transport-Security:
+      - max-age=63072000
+      X-Content-Type-Options:
+      - nosniff
+      X-Frame-Options:
+      - DENY
+      X-Request-Id:
+      - 623afde2-5a9d-4c65-953d-0331be842ae5
+    status: 200 OK
+    code: 200
+    duration: ""

internal/namespaces/vpcgw/v1/testdata/test-list-gateway-type-simple.golden

@@ -0,0 +1,18 @@
+🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
+🟩🟩🟩 STDOUT️ 🟩🟩🟩️
+NAME      BANDWIDTH   ZONE
+VPC-GW-S  100000000   fr-par-1
+VPC-GW-M  1000000000  fr-par-1
+🟩🟩🟩 JSON STDOUT 🟩🟩🟩
+[
+  {
+    "name": "VPC-GW-S",
+    "bandwidth": 100000000,
+    "zone": "fr-par-1"
+  },
+  {
+    "name": "VPC-GW-M",
+    "bandwidth": 1000000000,
+    "zone": "fr-par-1"
+  }
+]