feat(instance): remove unwanted required field on CreateSnapshot (#2493)

It is now possible to create a snapshot from an object storage bucket

Co-authored-by: Rémy Léone <rleone@scaleway.com>

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-instance-snapshot-create-usage.golden

@@ -20,7 +20,7 @@ EXAMPLES:
 
 ARGS:
   [name=<generated>]   Name of the snapshot
-  volume-id            UUID of the volume
+  [volume-id]          UUID of the volume
   [unified]            Whether a snapshot is unified or not.
   [tags.{index}]       The tags of the snapshot
   [project-id]         Project ID to use. If none is passed the default project ID will be used

docs/commands/instance.md

@@ -1928,7 +1928,7 @@ scw instance snapshot create [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | name | Default: `<generated>` | Name of the snapshot |
-| volume-id | Required | UUID of the volume |
+| volume-id |  | UUID of the volume |
 | unified |  | Whether a snapshot is unified or not. |
 | tags.{index} |  | The tags of the snapshot |
 | project-id |  | Project ID to use. If none is passed the default project ID will be used |

internal/namespaces/instance/v1/instance_cli.go

@@ -1269,7 +1269,7 @@ func instanceSnapshotCreate() *core.Command {
 			{
 				Name:       "volume-id",
 				Short:      `UUID of the volume`,
-				Required:   true,
+				Required:   false,
 				Deprecated: false,
 				Positional: false,
 			},