Skip to content

Commit 9367a2a

Browse files
authored
feat(lb): support dhcp/ipam private network (#3321)
1 parent d4d6915 commit 9367a2a

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

cmd/scw/testdata/test-all-usage-lb-private-network-attach-usage.golden

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,13 @@ USAGE:
66
scw lb private-network attach <lb-id ...> [arg=value ...]
77

88
ARGS:
9-
lb-id Load Balancer ID
10-
private-network-id Private Network ID
9+
lb-id Load Balancer ID
10+
private-network-id Private Network ID
11+
[dhcp-config.ip-id]
12+
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
13+
14+
DEPRECATED ARGS:
1115
[static-config.ip-address.{index}] Array of a local IP address for the Load Balancer on this Private Network
12-
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
1316

1417
FLAGS:
1518
-h, --help help for attach

docs/commands/lb.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1123,7 +1123,8 @@ scw lb private-network attach <lb-id ...> [arg=value ...]
11231123
|------|---|-------------|
11241124
| lb-id | Required | Load Balancer ID |
11251125
| private-network-id | Required | Private Network ID |
1126-
| static-config.ip-address.{index} | | Array of a local IP address for the Load Balancer on this Private Network |
1126+
| ~~static-config.ip-address.{index}~~ | Deprecated | Array of a local IP address for the Load Balancer on this Private Network |
1127+
| dhcp-config.ip-id | | |
11271128
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |
11281129

11291130

internal/namespaces/lb/v1/lb_cli.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3254,6 +3254,12 @@ func lbPrivateNetworkAttach() *core.Command {
32543254
Name: "static-config.ip-address.{index}",
32553255
Short: `Array of a local IP address for the Load Balancer on this Private Network`,
32563256
Required: false,
3257+
Deprecated: true,
3258+
Positional: false,
3259+
},
3260+
{
3261+
Name: "dhcp-config.ip-id",
3262+
Required: false,
32573263
Deprecated: false,
32583264
Positional: false,
32593265
},

0 commit comments

Comments
 (0)