fix(redis): send both ipam and service-ips to API for proper validation (#5045)

jremy42 · web-flow · commit 890afbd4760f · 2025-10-09T14:49:55.000Z
diff --git a/internal/namespaces/redis/v1/custom_cluster.go b/internal/namespaces/redis/v1/custom_cluster.go
@@ -72,10 +72,9 @@ func clusterCreateBuilder(c *core.Command) *core.Command {
 			if customEndpoint.PrivateNetwork == nil {
 				continue
 			}
-			ipamConfig := &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}
-			if !customEndpoint.PrivateNetwork.EnableIpam ||
-				len(customEndpoint.PrivateNetwork.ServiceIPs) > 0 {
-				ipamConfig = nil
+			var ipamConfig *redis.EndpointSpecPrivateNetworkSpecIpamConfig
+			if customEndpoint.PrivateNetwork.EnableIpam {
+				ipamConfig = &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}
 			}
 			createClusterRequest.Endpoints = append(
 				createClusterRequest.Endpoints,

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,9 @@ func clusterCreateBuilder(c core.Command) core.Command {`
`72`	`72`	`if customEndpoint.PrivateNetwork == nil {`
`73`	`73`	`continue`
`74`	`74`	`}`
`75`		`- ipamConfig := &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}`
`76`		`- if !customEndpoint.PrivateNetwork.EnableIpam \|\|`
`77`		`- len(customEndpoint.PrivateNetwork.ServiceIPs) > 0 {`
`78`		`- ipamConfig = nil`
	`75`	`+ var ipamConfig *redis.EndpointSpecPrivateNetworkSpecIpamConfig`
	`76`	`+ if customEndpoint.PrivateNetwork.EnableIpam {`
	`77`	`+ ipamConfig = &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}`
`79`	`78`	`}`
`80`	`79`	`createClusterRequest.Endpoints = append(`
`81`	`80`	`createClusterRequest.Endpoints,`