Skip to content

Commit 88fa35b

Browse files
Mia-CrossMia-Cross
authored
test(rdb): fix tests + update cassettes and goldens (#3480)
1 parent 20deb6c commit 88fa35b

File tree

50 files changed

+19930
-7562
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+19930
-7562
lines changed

‎internal/namespaces/rdb/v1/custom_backup_test.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func Test_CreateBackup(t *testing.T) {
2222
},
2323
),
2424
),
25-
Cmd: "scw rdb backup create name=foobar expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
25+
Cmd: "scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
2626
Check: core.TestCheckGolden(),
2727
AfterFunc: deleteInstance(),
2828
DefaultRegion: scw.RegionNlAms,
@@ -43,7 +43,7 @@ func Test_RestoreBackup(t *testing.T) {
4343
),
4444
core.ExecStoreBeforeCmd(
4545
"Backup",
46-
"scw rdb backup create name=foobar expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
46+
"scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
4747
),
4848
),
4949
Cmd: "scw rdb backup restore {{ .Backup.ID }} instance-id={{ .Instance.ID }} --wait",
@@ -69,7 +69,7 @@ func Test_ExportBackup(t *testing.T) {
6969
),
7070
core.ExecStoreBeforeCmd(
7171
"Backup",
72-
"scw rdb backup create name=foobar expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
72+
"scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
7373
),
7474
),
7575
Cmd: "scw rdb backup export {{ .Backup.ID }} --wait",
@@ -88,7 +88,7 @@ func Test_DownloadBackup(t *testing.T) {
8888
createInstance(engine),
8989
core.ExecStoreBeforeCmd(
9090
"Backup",
91-
"scw rdb backup create name=foobar expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
91+
"scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
9292
),
9393
core.ExecStoreBeforeCmd(
9494
"BackupExport",
@@ -117,7 +117,7 @@ func Test_DownloadBackup(t *testing.T) {
117117
createInstance(engine),
118118
core.ExecStoreBeforeCmd(
119119
"Backup",
120-
"scw rdb backup create name=foobar expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
120+
"scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
121121
),
122122
),
123123
Cmd: "scw rdb backup download {{ .Backup.ID }} output=no_previous_export_dump",
@@ -139,19 +139,19 @@ func Test_DownloadBackup(t *testing.T) {
139139

140140
// If ran please update the cassette by changing 'download_url_expires_at'
141141
// when it's not null to a much later date
142-
// E.g. from "2022-09-05T13:14:54.437192Z" to "2999-09-05T13:14:54.437192Z"
142+
// E.g. from "2022-09-05T13:14:54.437192Z" to "2032-09-05T13:14:54.437192Z"
143143
func Test_ListBackup(t *testing.T) {
144144
t.Run("Simple", core.Test(&core.TestConfig{
145145
Commands: GetCommands(),
146146
BeforeFunc: core.BeforeFuncCombine(
147147
createInstance(engine),
148148
core.ExecStoreBeforeCmd(
149149
"BackupA",
150-
"scw rdb backup create name=will_be_exported expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
150+
"scw rdb backup create name=will_be_exported expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
151151
),
152152
core.ExecStoreBeforeCmd(
153153
"BackupB",
154-
"scw rdb backup create name=will_not_be_exported expires-at=2999-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
154+
"scw rdb backup create name=will_not_be_exported expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
155155
),
156156
core.ExecStoreBeforeCmd(
157157
"BackupExport",

‎internal/namespaces/rdb/v1/custom_instance_test.go‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ func Test_UpdateInstance(t *testing.T) {
101101
Cmd: "scw rdb instance update {{ .Instance.ID }} settings.0.name=timezone settings.0.value=UTC --wait",
102102
Check: core.TestCheckCombine(
103103
func(t *testing.T, ctx *core.CheckFuncCtx) {
104-
assert.Equal(t, "timezone", ctx.Result.(*rdb.Instance).Settings[6].Name)
105-
assert.Equal(t, "UTC", ctx.Result.(*rdb.Instance).Settings[6].Value)
104+
assert.Equal(t, "timezone", ctx.Result.(*rdb.Instance).Settings[5].Name)
105+
assert.Equal(t, "UTC", ctx.Result.(*rdb.Instance).Settings[5].Value)
106106
},
107107
core.TestCheckGolden(),
108108
core.TestCheckExitCode(0),
@@ -116,8 +116,8 @@ func Test_UpdateInstance(t *testing.T) {
116116
Cmd: "scw rdb instance update {{ .Instance.ID }} settings.0.name=work_mem settings.0.value=8 --wait",
117117
Check: core.TestCheckCombine(
118118
func(t *testing.T, ctx *core.CheckFuncCtx) {
119-
assert.Equal(t, "work_mem", ctx.Result.(*rdb.Instance).Settings[0].Name)
120-
assert.Equal(t, "8", ctx.Result.(*rdb.Instance).Settings[0].Value)
119+
assert.Equal(t, "work_mem", ctx.Result.(*rdb.Instance).Settings[5].Name)
120+
assert.Equal(t, "8", ctx.Result.(*rdb.Instance).Settings[5].Value)
121121
},
122122
core.TestCheckGolden(),
123123
core.TestCheckExitCode(0),
@@ -141,14 +141,14 @@ func Test_UpdateInstance(t *testing.T) {
141141
" name=foo2 --wait",
142142
Check: core.TestCheckCombine(
143143
func(t *testing.T, ctx *core.CheckFuncCtx) {
144-
assert.Equal(t, "work_mem", ctx.Result.(*rdb.Instance).Settings[0].Name)
145-
assert.Equal(t, "16", ctx.Result.(*rdb.Instance).Settings[0].Value)
146-
assert.Equal(t, "max_connections", ctx.Result.(*rdb.Instance).Settings[1].Name)
147-
assert.Equal(t, "150", ctx.Result.(*rdb.Instance).Settings[1].Value)
148-
assert.Equal(t, "effective_cache_size", ctx.Result.(*rdb.Instance).Settings[2].Name)
149-
assert.Equal(t, "1200", ctx.Result.(*rdb.Instance).Settings[2].Value)
150-
assert.Equal(t, "maintenance_work_mem", ctx.Result.(*rdb.Instance).Settings[3].Name)
151-
assert.Equal(t, "200", ctx.Result.(*rdb.Instance).Settings[3].Value)
144+
assert.Equal(t, "effective_cache_size", ctx.Result.(*rdb.Instance).Settings[0].Name)
145+
assert.Equal(t, "1200", ctx.Result.(*rdb.Instance).Settings[0].Value)
146+
assert.Equal(t, "maintenance_work_mem", ctx.Result.(*rdb.Instance).Settings[1].Name)
147+
assert.Equal(t, "200", ctx.Result.(*rdb.Instance).Settings[1].Value)
148+
assert.Equal(t, "max_connections", ctx.Result.(*rdb.Instance).Settings[2].Name)
149+
assert.Equal(t, "150", ctx.Result.(*rdb.Instance).Settings[2].Value)
150+
assert.Equal(t, "work_mem", ctx.Result.(*rdb.Instance).Settings[5].Name)
151+
assert.Equal(t, "16", ctx.Result.(*rdb.Instance).Settings[5].Value)
152152
assert.Equal(t, "foo2", ctx.Result.(*rdb.Instance).Name)
153153
},
154154
core.TestCheckGolden(),

0 commit comments

Comments
 (0)